Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protected methods to customize client thread names. #1422

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NathanSweet
Copy link

@NathanSweet NathanSweet commented Jun 16, 2024

Description

New protected methods allow the default thread names to be customized.

Related Issue

#1421

Motivation and Context

This is useful in projects that have many threads and like to stay organized.

It is also useful when using multiple clients. Each client can name its threads differently. Without this, the threads can't be differentiated by name.

An alternative solution could be a prefix that is used for thread names, with suffixes like:

threadPrefix + "-read-" + id
threadPrefix + "-write-" + id
threadPrefix + "-checkConnection" (or "-connectionMonitor"?)

LMK if you would prefer that and I'll update the PR.

Server thread names are not considered in this PR.

How Has This Been Tested?

It's very simple, running the client tests all changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant