Skip to content

Conversation

@bryates
Copy link
Contributor

@bryates bryates commented Apr 22, 2024

The CI script test_make_1d_quad_plots.py has been failing

The CI script `test_make_1d_quad_plots.py` has been failing due to broken root file path.
@bryates bryates requested review from Andrew42 and sscruz April 22, 2024 16:19
@codecov
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.52%. Comparing base (3ae0f05) to head (f6dd373).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   27.17%   27.52%   +0.35%     
==========================================
  Files          28       28              
  Lines        4225     4225              
==========================================
+ Hits         1148     1163      +15     
+ Misses       3077     3062      -15     
Flag Coverage Δ
unittests 27.52% <ø> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryates
Copy link
Contributor Author

bryates commented Jul 12, 2024

@sscruz @Andrew42 did either of you have comments on this? It's just a small change to the CI.

@bryates
Copy link
Contributor Author

bryates commented Feb 10, 2025

@sscruz @Andrew42 did either of you have comments on this? It's just a small change to the CI.

@Andrew42 @sscruz ?

@anpicci
Copy link
Collaborator

anpicci commented Oct 9, 2025

Hi @bryates , is this PR still relevant?

anpicci added a commit that referenced this pull request Nov 11, 2025
…-helper-functions

Refactor ratio window logic into helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants