Skip to content

Conversation

@ywan2
Copy link
Contributor

@ywan2 ywan2 commented Jun 3, 2025

datacard_tools.py is updated for:

  • new topcoffea scalings function parsing.
  • asimov datacard fix function fix.

As for changing the datacard WC values, it's still subject to better changes.

@ywan2 ywan2 requested a review from bryates June 3, 2025 14:01
@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 25.34%. Comparing base (3471b74) to head (f659568).

Files with missing lines Patch % Lines
topeft/modules/datacard_tools.py 18.18% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   25.43%   25.34%   -0.10%     
==========================================
  Files          35       35              
  Lines        5185     5189       +4     
==========================================
- Hits         1319     1315       -4     
- Misses       3866     3874       +8     
Flag Coverage Δ
unittests 25.34% <18.18%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bryates bryates requested review from Andrew42, bryates and sscruz June 3, 2025 17:12
@bryates
Copy link
Contributor

bryates commented Jun 20, 2025

@Andrew42 did you have any comments on this PR?

@anpicci
Copy link
Collaborator

anpicci commented Oct 9, 2025

@bryates, do you think we should ping Andrew privately about this PR?

anpicci added a commit that referenced this pull request Nov 11, 2025
…cr_and_sr_plots.py

Gate category fan-out on available workers
@bryates
Copy link
Contributor

bryates commented Dec 11, 2025

@bryates, do you think we should ping Andrew privately about this PR?

@ywan2 looks like there is now a merge conflict in this PR. Can you fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants