Skip to content

Conversation

@bryates
Copy link
Contributor

@bryates bryates commented Aug 15, 2025

I've added a set of validation scripts I wrote, along with a few I got from @hannahbnelson. We should have a few volunteers test these out to make sure I didn't leave off any important info. @ywan2 has already used most of these (though some names have changed) and Sneha is currently learning some of these steps.

EDIT:
We also had the wrong ttH xsec used for 2022_ttHnobb-1Jets.json (it was set to the full ttH xsec instead of ttH no bbbar)

@bryates bryates self-assigned this Aug 15, 2025
@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.09%. Comparing base (5dceaf7) to head (b8c1a0d).
⚠️ Report is 189 commits behind head on master.

Files with missing lines Patch % Lines
analysis/topeft_run2/make_jsons_fast.py 0.00% 59 Missing ⚠️
analysis/topeft_run2/make_jsons.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #491      +/-   ##
==========================================
- Coverage   25.38%   25.09%   -0.29%     
==========================================
  Files          35       36       +1     
  Lines        5232     5291      +59     
==========================================
  Hits         1328     1328              
- Misses       3904     3963      +59     
Flag Coverage Δ
unittests 25.09% <0.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Andrew42 Andrew42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a fair bit of commented out "junk", but aside from that I think this is fine to merge.

@bryates bryates merged commit f673f02 into master Dec 11, 2025
2 checks passed
@bryates bryates deleted the validation_scripts branch December 11, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants