Skip to content

Conversation

@ywan2
Copy link
Contributor

@ywan2 ywan2 commented Sep 10, 2025

This PR includes the updates from all run2 contributions:

  • 2l & 3l fwd channel addition with fwd jet 2.5>eta>5 (--fwd-analysis)
  • 3loffZ division into low, high, and none, based on invariant mass and count of sfos lepton pair (--offZ-split)
  • adding hadronically decaying taus. (--tau-h-analysis)

A new tag --all-analysis is added to run_analysis to run processor integrating all contributions.

@bryates
Copy link
Contributor

bryates commented Sep 24, 2025

Thanks for fixing the merge conflicts @ywan2. There are still a few comments left, but let me know if you have any trouble addressing them. Since the runner currently cannot connect to ND, we don't have a working CI. @Andrew42 @sscruz would you be ok with @ywan2 running a check locally to make sure the yields don't change with respect to the master branch, or should we work to get the CI back up?

@bryates bryates requested review from Andrew42 and sscruz September 29, 2025 18:33
@ywan2
Copy link
Contributor Author

ywan2 commented Oct 20, 2025

@bryates I reran CI and codecov issue is gone. I think this PR is ready.

@bryates
Copy link
Contributor

bryates commented Oct 21, 2025

@bryates I reran CI and codecov issue is gone. I think this PR is ready.

Thanks @ywan2. Can you address the remaining comments?

@bryates bryates self-requested a review November 6, 2025 15:34
@bryates
Copy link
Contributor

bryates commented Nov 6, 2025

If @anpicci @Andrew42 and @sscruz have no further comments, I think this PR is ready to merge.

Copy link
Collaborator

@anpicci anpicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also fine with this PR. Thank you for the efforts @bryates and @ywan2 !

@ywan2 ywan2 merged commit fb49082 into master Nov 7, 2025
4 checks passed
@bryates bryates deleted the run2-all-updates branch November 7, 2025 17:26
anpicci added a commit that referenced this pull request Nov 12, 2025
…lper

Canonicalize data-driven histogram keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants