Skip to content

tau fixes: dm-dependent SFs, VVLoose WP for VSe used everywhere, igno… #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anpicci wants to merge 6 commits into
base: run3_test_mmerged
Choose a base branch
from
+531 −171
Open

tau fixes: dm-dependent SFs, VVLoose WP for VSe used everywhere, igno… #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a387ad4
tau fixes: dm-dependent SFs, VVLoose WP for VSe used everywhere, igno…
anpicci Dec 15, 2025
a4e46f4
devs
anpicci Dec 15, 2025
5e01f1d
original devs
anpicci Dec 15, 2025
25dd5b5
final devs
anpicci Dec 15, 2025
c2da7ca
separated plotted tau pts
anpicci Dec 17, 2025
e444ef3
fixing tau vetos in the CRs
anpicci Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 57 additions & 35 deletions analysis/topeft_run2/analysis_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,10 @@ def process(self, events):
xsec = self._samples[dataset]["xsec"]
sow = self._samples[dataset]["nSumOfWeights"]

print("\n\n\n\n\n")
print("histAxisName:", histAxisName)
print("\n\n\n\n\n")

is_run3 = False
if year.startswith("202"):
is_run3 = True
Expand Down Expand Up @@ -495,7 +499,9 @@ def _log_tau_flag_counts(label, flag_arrays):
################### Tau selection ####################

if self.tau_h_analysis:
tau["pt"], tau["mass"] = ApplyTES(year, tau, isData)
tau_fo_tag = "VLoose" if is_run2 else "Loose"
tau_T_tag = "Loose" if is_run2 else "Medium"

if is_run2:
vs_jet = tau.idDeepTau2017v2p1VSjet
vs_e = tau.idDeepTau2017v2p1VSe
Expand All @@ -505,8 +511,11 @@ def _log_tau_flag_counts(label, flag_arrays):
vs_e = tau.idDeepTau2018v2p5VSe
vs_mu = tau.idDeepTau2018v2p5VSmu

tau["pt"], tau["mass"] = ApplyTES(year, tau, isData, tau_T_tag)

tau["isVLoose"] = tauSelection.isVLooseTau(vs_jet)
tau["isLoose"] = tauSelection.isLooseTau(vs_jet)
tau["isMedium"] = tauSelection.isMediumTau(vs_jet)
tau["iseTight"] = tauSelection.iseTightTau(vs_e)
tau["ismTight"] = ak.values_astype(tauSelection.ismTightTau(vs_mu), np.int8)
tau["isPresVLoose"] = tauSelection.isPresTau(
Expand All @@ -531,7 +540,19 @@ def _log_tau_flag_counts(label, flag_arrays):
minpt=20,
vsJetWP="Loose",
)
tau["isPres"] = tau["isPresVLoose"]
tau["isPresMedium"] = tauSelection.isPresTau(
tau.pt,
tau.eta,
tau.dxy,
tau.dz,
vs_jet,
vs_e,
vs_mu,
minpt=20,
vsJetWP="Medium",
)

tau["isPres"] = tau[f"isPres{tau_fo_tag}"]

tau["isClean"] = te_os.isClean(tau, l_fo, drmin=0.3)
tau["isGood"] = tau["isClean"] & tau["isPres"]
Expand Down Expand Up @@ -559,28 +580,28 @@ def _log_tau_flag_counts(label, flag_arrays):
)
tau = tau[tau['DMflag']]

tau_vloose = tau
tau_vloose_padded = ak.pad_none(tau_vloose, 1)
tau0_vloose = tau_vloose_padded[:,0]
tau_fo = tau
tau_fo_padded = ak.pad_none(tau_fo, 1)
tau0_fo = tau_fo_padded[:,0]

tau_loose = tau_vloose[tau_vloose["isLoose"]>0]
tau_loose_padded = ak.pad_none(tau_loose, 1)
tau0_loose = tau_loose_padded[:,0]
tau_T = tau_fo[tau_fo["isLoose"]>0]
tau_T_padded = ak.pad_none(tau_T, 1)
tau0_T = tau_T_padded[:,0]

cleaning_taus = tau_loose
nLtau = ak.num(tau_loose)
cleaning_taus = tau_T
nLtau = ak.num(tau_T)

if self.tau_run_mode == "standard":
tau_F_mask = (ak.num(tau_vloose) == 1)
tau_F_mask = (ak.num(tau_fo) == 1)
tau_L_mask = (nLtau == 1)
elif self.tau_run_mode == "taufitter":
tau_F_mask = (ak.num(tau_vloose) >= 1)
tau_F_mask = (ak.num(tau_fo) >= 1)
tau_L_mask = (nLtau >= 1)
else:
raise ValueError(f"Unknown tau_run_mode '{self.tau_run_mode}'")
no_tau_mask = (nLtau == 0)

tau0 = ak.where(tau_L_mask, tau0_loose, tau0_vloose)
tau0 = tau0_T

_log_tau_flag_counts(
"tau_h_event_masks",
Expand All @@ -592,20 +613,16 @@ def _log_tau_flag_counts(label, flag_arrays):
)

if not isData:
AttachTauSF(events, tau_loose, year=year, vsJetWP="Loose")

# if (not self._tau_wp_checked) and len(events) > 0:
# n_tau_vloose = int(ak.sum(tau_F_mask))
# n_tau_loose = int(ak.sum(tau_L_mask))
# n_tau_vloose_only = int(ak.sum(tau_F_mask & ~tau_L_mask))
# print(
# f"\n\n\n\n\n\n\n\n\n[Tau WP check - {self.tau_run_mode}] Events with >=1 VLoose tau: {ak.to_list(n_tau_vloose)};\n>=1 Loose tau: {ak.to_list(n_tau_loose)};\nVLoose-only: {ak.to_list(n_tau_vloose_only)}\n\n\n\n\n\n\n\n\n"
# )
# if self.tau_run_mode == "standard":
# masks_identical = bool(ak.all(tau_F_mask == tau_L_mask)) if len(events) > 0 else False
# if masks_identical and (n_tau_vloose > 0 or n_tau_loose > 0):
# raise AssertionError("Ftau and Ttau masks are identical; check tau WP separation")
# self._tau_wp_checked = True
AttachTauSF(events, tau_T, year=year, vsJetWP=tau_T_tag)
# print("\n\n\n\n\n\n")
# print("taus[pt]", ak.to_list(tau_T.pt))
# print("taus[isLoose]", ak.to_list(tau_T.isLoose))
# print("taus[isMedium]", ak.to_list(tau_T.isMedium))
# print("taus[sf_tau_real]", ak.to_list(tau_T.sf_tau_real))
# print("taus[sf_tau_fake]", ak.to_list(tau_T.sf_tau_fake))
# print("events[sf_2l_taus_real]", ak.to_list(events["sf_2l_taus_real"]))
# print("events[sf_2l_taus_fake]", ak.to_list(events["sf_2l_taus_fake"]))
# print("\n\n\n\n\n\n")

else:
if is_run2:
Expand Down Expand Up @@ -763,8 +780,8 @@ def _log_tau_flag_counts(label, flag_arrays):
if not isData:
cleanedJets["pt_gen"] = ak.values_astype(ak.fill_none(cleanedJets.matched_gen.pt, 0), np.float32)
if self.tau_h_analysis:
tau["pt"], tau["mass"] = ApplyTESSystematic(year, tau, isData, syst_var)
tau["pt"], tau["mass"] = ApplyFESSystematic(year, tau, isData, syst_var)
tau["pt"], tau["mass"] = ApplyTESSystematic(year, tau, isData, syst_var, tau_T_tag)
tau["pt"], tau["mass"] = ApplyFESSystematic(year, tau, isData, syst_var, tau_T_tag)

events_cache = events.caches[0]
cleanedJets = ApplyJetCorrections(year, corr_type='jets', isData=isData, era=run_era).build(cleanedJets, lazy_cache=events_cache) #Run3 ready
Expand Down Expand Up @@ -932,23 +949,27 @@ def _log_tau_flag_counts(label, flag_arrays):
select_cat_dict = json.load(ch_json_test)

if not self._skip_signal_regions:
# If we are not skipping the signal regions, we will import the SR categories
# If we are not skipping the signal regions, we will import the SR categories
# This dictionary keeps track of which selections go with which SR categories
if self.offZ_3l_split:
import_sr_cat_dict = select_cat_dict["OFFZ_SPLIT_CH_LST_SR"]
elif self.tau_h_analysis:
import_sr_cat_dict = select_cat_dict["TAU_CH_LST_SR"]
elif self.fwd_analysis:
import_sr_cat_dict = select_cat_dict["FWD_CH_LST_SR"]
elif self.all_analysis:
import_sr_cat_dict = select_cat_dict["ALL_CH_LST_SR"]
else:
import_sr_cat_dict = select_cat_dict["TOP22_006_CH_LST_SR"]

if not self._skip_control_regions:
# If we are not skipping the control regions, we will import the CR categories
# If we are not skipping the control regions, we will import the CR categories
# This dictionary keeps track of which selections go with which CR categories
import_cr_cat_dict = select_cat_dict["CH_LST_CR"]
if self.tau_h_analysis:
import_cr_cat_dict.update(select_cat_dict["TAU_CH_LST_CR"])
if self.tau_h_analysis or self.all_analysis:
import_cr_cat_dict = select_cat_dict["TAU_CH_LST_CR"]
else:
import_cr_cat_dict = select_cat_dict["CH_LST_CR"]


#This list keeps track of the lepton categories
lep_cats = []
Expand Down Expand Up @@ -1414,7 +1435,8 @@ def _log_tau_flag_counts(label, flag_arrays):

if self.tau_h_analysis:
varnames["ptz_wtau"] = ptz_wtau
varnames["tau0pt"] = tau0.pt
varnames["tau0Tpt"] = tau0_T.pt
varnames["tau0Fpt"] = tau0_fo.pt
pass

for varname, var in varnames.items():
Expand Down
12 changes: 9 additions & 3 deletions analysis/topeft_run2/run_analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,8 @@ def _cleanup_work_queue_staging_directory(path, eligible_for_cleanup):
hist_lst = ["njets", "lj0pt", "ptz"]
if tau_h_analysis:
hist_lst.append("ptz_wtau")
hist_lst.append("tau0pt")
hist_lst.append("tau0Tpt")
hist_lst.append("tau0Fpt")
if fwd_analysis:
hist_lst.append("lt")
if "lepton_pt_vs_eta" not in hist_lst:
Expand Down Expand Up @@ -560,7 +561,8 @@ def _cleanup_work_queue_staging_directory(path, eligible_for_cleanup):
# "l1_eta_vs_phi",
]
if tau_h_analysis:
hist_lst.append("tau0pt")
hist_lst.append("tau0Tpt")
hist_lst.append("tau0Fpt")
else:
# We want to specify a custom list
# If we don't specify this argument, it will be None, and the processor will fill all hists
Expand Down Expand Up @@ -606,7 +608,7 @@ def LoadJsonToSampleName(jsonFile, prefix):
# Open cfg files
else:
with open(f) as fin:
print(" >> Reading json from cfg file...")
print(" >> Reading json from cfg file...", f)
lines = fin.readlines()
for l in lines:
if "#" in l:
Expand Down Expand Up @@ -679,7 +681,11 @@ def LoadJsonToSampleName(jsonFile, prefix):

requested_years.update(year_synonyms.get(year_str, {year_str}))

print(">> Loaded a total of %i samples from json files." % len(samplesdict))
print("requested_years:", requested_years)

if requested_years is not None:
print([sample.get("year") for sample in samplesdict.values()])
samplesdict = {
name: sample
for name, sample in samplesdict.items()
Expand Down
Loading