401 epic improve networking layer #406
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-garbacz
changed the title
b-garbacz
force-pushed
the
401-epic-improve-networking-layer
branch
from
070e1a8 to
0ec08c5
Compare
* feat: initial protobuf design for network messages (#405) * feat: initial protobuf design for network messages (#405) * chore: renname operations.js to applyOperations.js * feat: implement builder for v1 internal protocol messages * feat(test): add tests for NetworkMessageBuilder and NetworkMessageDirector * chore: refactor message builders and directors to remove StateBuilder inheritance * feat(test): implement encoding and decoding functions for v1 network operations * feat(test): add fixtures for v1 network operation payloads * chore: delete redundant file networkOperations.js * fix: update NetworkMessageBuilder and director to use mainnet config and address prefix validation * fix(test): adjust calling instantion of the CompleteStateMessageDirector and builder. * feat: Implement ApplyStateMessageBuilder.js and regression tests * refactor: decouple partial validators from wallet * fix: update error message for missing transaction payload in broadcastTransaction * feat: delete reset method in ApplyStateMessageBuilder and implement simple factory for message creation * refactor: rename message building methods to indicate completion phase * refactor: swap partial/complete builders with ApplyStateMessage builder. * refactor(test): swap new builder with old builders. * refactor: refactor old builder with new one for message creation in network layer * test: add unit tests for normalization functions in utils * fix(test): implement new tests for apply messages builder and delete old broken tests * refactor(test): reorganize network message tests and update import paths * refactor: delete outdated partial and complete builders and regression test * docs: add jsdocs for new builders * refactor: rename createApplyStateMessageFactory to applyStateMessageFactory and update related imports
b-garbacz
force-pushed
the
401-epic-improve-networking-layer
branch
from
6fe7d2b to
0af2023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.