Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master<-dev #1037

Merged
merged 44 commits into from
Sep 24, 2024
Merged

master<-dev #1037

merged 44 commits into from
Sep 24, 2024

Conversation

TinyKitten
Copy link
Member

@TinyKitten TinyKitten commented Sep 21, 2024

データ対応と種別自動選択修正

@TinyKitten TinyKitten self-assigned this Sep 21, 2024
@TinyKitten
Copy link
Member Author

TinyKitten commented Sep 21, 2024

https://github.com/TrainLCD/StationAPI/pull/1037/files#diff-cf7f7a75a67e6bcce90e5a63d9cb85a5c805852ec821096310a97fa07d2cef61R4924
新しく追加されたデータがstationsのデータ(未公開)に依存しているためこのPRをマージするにはstation_station_typesを元に戻すかstationsのデータを修正後のデータでも問題がなくなるようにAPIかアプリまたは両方のバグの修正が必要

#1018 (comment)
station_station_typesを元に戻すのは建設的ではなく負債になるので自動種別選択が機能していない件の対処が必要

仙石東北ライン追加
@TinyKitten TinyKitten marked this pull request as ready for review September 23, 2024 18:16
@TinyKitten TinyKitten marked this pull request as draft September 23, 2024 18:17
@TinyKitten
Copy link
Member Author

路線リストでどの種別でも停車しない駅は含まない修正を行ったら動作確認->マージ->リリース

@TinyKitten TinyKitten marked this pull request as ready for review September 23, 2024 19:00
@TinyKitten
Copy link
Member Author

種別自動選択の準備もできたのでデグレ確認だけしてマージ

@TinyKitten TinyKitten merged commit ed8efe1 into master Sep 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants