Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

経路検索パフォチュー #992

Merged
merged 3 commits into from
Sep 10, 2024
Merged

経路検索パフォチュー #992

merged 3 commits into from
Sep 10, 2024

Conversation

TinyKitten
Copy link
Member

@TinyKitten TinyKitten commented Sep 10, 2024

新宿三丁目->元町・中華街でPostman検証
{"from_station_group_id": 2800217,"to_station_group_id": 9931006}

dev

376.43 ms
529.5 ms
409.12 ms

fix/search-perf

427.99 ms
392.75 ms
453.53 ms

devとそんなに変わらないように見えるが500msを超える頻度が減っているので効果ないわけではなさそう

6309b4f
↑の対応後400ms以下のレスポンスが続いた

358.78 ms
359.28 ms
358.46 ms

@TinyKitten TinyKitten self-assigned this Sep 10, 2024
@TinyKitten
Copy link
Member Author

コード見づらくなったのと目立った成果がないので一旦塩漬けする

@TinyKitten TinyKitten marked this pull request as draft September 10, 2024 10:57
@TinyKitten
Copy link
Member Author

このPRみたいに「適当な環境、適当なパラメタで適当にベンチマークしたら~ms変わったよ」とかじゃなくてちゃんとしたフォーマットを考えるべきかもしれない #993

@TinyKitten TinyKitten marked this pull request as ready for review September 10, 2024 13:16
@TinyKitten
Copy link
Member Author

stgにデプロイして様子見

@TinyKitten TinyKitten merged commit 844c4b3 into dev Sep 10, 2024
10 checks passed
@TinyKitten TinyKitten deleted the fix/search-perf branch September 10, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant