-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve frontpage visuals, frontmatter dx #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andretchen0 I think we should add also a Fab button to the single pages so the user can access directly the code similar of what threejs examples does |
Hey @alvarosabu , I'll look into adding the code button to individual demos and push here. Yeah, labels need some attention. I'll tackle those in a separate PR. |
I've added buttons to the demos. It looks a bit unorganized in some of the demos as they add their own UI elements with different spacing/offsets. |
Hey @JaimeTorrealba @alvarosabu , Bumping. Can we merge here? I think this takes care of all of @alvarosabu 's modification requests, but the PR hasn't been approved. There's another lab demo in the works – #110 – and I'd like to get the updated lab online so we can spare ourselves the work of cropping thumbnails, etc. Thanks! |
Hey @andretchen0 I saw the new changes, they look good but there is something odd with the navigation and the github button. For some reason if you enter an experiment from the Try changing the Nuxt link for a normal anchor, sometimes NuxtLink does weird stuff when going to external links Screen.Recording.2024-04-16.at.15.07.46.mov |
Thanks @alvarosabu for the pointer. I'll check it out. |
@andretchen0 should we merge this one and you check the routing issue in another or we just wait? |
Hey @alvarosabu , I've removed the NuxtLink on the code buttons. They're just normal I wasn't able to reproduce the bug. Maybe something to do with how I'm running the dev site? Are you able to reproduce the bug now? If so, any other ideas? Fwiw, feel free to push to this branch if that helps us get to a merge. |
Hey @alvarosabu , bumping. Could you have a look and tell me if we can merge and close here? Thanks! |
This PR contains various chores and quality-of-life improvements related to the Lab's landing page. They're largely in separate commits, so no problem rolling back all or some changes.
Problem
Thumbnails had various sizes. #111
Solution
Make all thumbnails 16:9.
@JaimeTorrealba , have a look at the glass demo thumbnail. I couldn't retake it because the texture in the demo is very light on my screen. Feel free to push a new thumbnail to this PR, if you like.
Problem
Some demos had code examples in their
.md
files. Others did not. #90Solution
NOTE:
components/content/glass-example
tocontent/experiements/glass-material.md
in order to make the Github links.And since we are deriving Github links from demo names ...
Problem
.md
frontmatter contained some fields that could be derived. E.g., from the path tocontent/experiments/my-awesome-demo
we can derive:title: My Awesome Demo
thumbnail: my-awesome-demo.png
slug: my-awesome-demo
Solution
.md
files.Problem
status: published
tripped me up a few timesSolution
status: published
, but if nostatus
is set, assumepublished
.status: unpublished
to the 'hidden' demos'.md
files.Problem
Whitespace at the bottom of the screen in dark mode:
Solution
Fix the CSS. (Swap margin for padding.)
Closes #111, #90