This repository was archived by the owner on Feb 1, 2026. It is now read-only.
fix: specify modules when autoimport post-processing#144
Open
alvarosabu wants to merge 1 commit intomainfrom
Open
fix: specify modules when autoimport post-processing#144alvarosabu wants to merge 1 commit intomainfrom
alvarosabu wants to merge 1 commit intomainfrom
Conversation
Member
Author
|
@Tinoooo @damienmontastier, we have an issue with compatibility because of how we decided to architecture the |
Member
|
@alvarosabu Instead of having 2 exports (for three and pmdrs), would it be better to have a UnrealBloom folder, with the Three.js effect and the Pmdrs effect inside?
To call each effect (Glitch, UnrealBloom, etc), we could imagine using either :
OR
|
Member
Member
|
I'm going to prepare another PR here (will supersede this PR), we only need to do some hack before registering the imports... |
Tinoooo
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with the stable release of post-processing