Use correct functions for ascending/descending node calculations #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems KSP 1.12 added functions to Orbit with the same name as KAC extensions, thus the extensions were no longer called. This resulted in great confusion about where the AN vector pointed, its true anomaly, and the time of that true anomaly. This makes use of the functions that are provided by the Orbit class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems KSP 1.12 added functions to Orbit with the same name as KAC
extensions, thus the extensions were no longer called. This resulted in
great confusion about where the AN vector pointed, its true anomaly, and
the time of that true anomaly. This makes use of the functions that are
provided by the Orbit class.