Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sharePath url option setting #1288

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

maphew
Copy link
Contributor

@maphew maphew commented Feb 26, 2025

This is a follow up to #1207 bare2share: adding a sharePath option setting under Other so that the anonymous url path can be / or /foo instead of hardcoded to /share.

The options setting page is setup and works in that the setting is saved, but routing for anonymous user is broken. I'm stuck for now.

(meta: npx prettier has not been run. Also I don't see the control for setting this PR to draft, sorry. Review still welcome though!)

@pano9000
Copy link
Member

I've put it into draft for you :-)

will have a look at this later this evening (CET time :-)) - this time hopefully without too much confusion from my side ;-)

@JYC333
Copy link
Member

JYC333 commented Apr 2, 2025

Is this still valid and ongoing?

@maphew
Copy link
Contributor Author

maphew commented Apr 2, 2025

@JYC333 I still want it, if that counts :). I'm stuck with how to complete the implementation though.

@JYC333
Copy link
Member

JYC333 commented Apr 2, 2025

I can try to take a look if you don't mind

@maphew
Copy link
Contributor Author

maphew commented Apr 3, 2025

that would be wonderful, thank you!

@eliandoran eliandoran added this to the v0.93.0 milestone Apr 3, 2025
@maphew
Copy link
Contributor Author

maphew commented Apr 4, 2025

merge fbe7d64 just catches the branch up to develop right? It doesn't yet attempt to address the anonymous routing problem I got stuck on?

Just checking because with these changes I still get "checkAuth: Redirecting to share path. From: /, To: /share" in console with "Firefox has detected that the server is redirecting the request for this address in a way that will never complete." in browser. However I'm not sure my local dev folder is clean.

@JYC333
Copy link
Member

JYC333 commented Apr 4, 2025

Yes, it's just merging develop for now, still look into the problem. Probably won't finish today through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants