-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sharePath url option setting #1288
base: develop
Are you sure you want to change the base?
Conversation
I've put it into draft for you :-) will have a look at this later this evening (CET time :-)) - this time hopefully without too much confusion from my side ;-) |
1st time using Meld. I'm not sure if the conflict resolve is clean
Is this still valid and ongoing? |
@JYC333 I still want it, if that counts :). I'm stuck with how to complete the implementation though. |
I can try to take a look if you don't mind |
that would be wonderful, thank you! |
merge fbe7d64 just catches the branch up to develop right? It doesn't yet attempt to address the anonymous routing problem I got stuck on? Just checking because with these changes I still get "checkAuth: Redirecting to share path. From: /, To: /share" in console with "Firefox has detected that the server is redirecting the request for this address in a way that will never complete." in browser. However I'm not sure my local dev folder is clean. |
Yes, it's just merging develop for now, still look into the problem. Probably won't finish today through. |
This is a follow up to #1207 bare2share: adding a sharePath option setting under Other so that the anonymous url path can be
/
or/foo
instead of hardcoded to/share
.The options setting page is setup and works in that the setting is saved, but routing for anonymous user is broken. I'm stuck for now.
(meta: npx prettier has not been run. Also I don't see the control for setting this PR to draft, sorry. Review still welcome though!)