Skip to content

style: bring the workspace up to the strict clippy gate - #2

Merged
yordis merged 2 commits into
mainfrom
yordis/fix-clippy-gate
Sep 1, 2026
Merged

style: bring the workspace up to the strict clippy gate#2
yordis merged 2 commits into
mainfrom
yordis/fix-clippy-gate

Conversation

@yordis

@yordis yordis commented Sep 1, 2026

Copy link
Copy Markdown
Member
  • The strict clippy gate landed in 5ccc405 without the code that satisfies it, so every branch and every fork inherits a red CI that says nothing about the change under review.
  • A gate that has never been green trains everyone to ignore it; bringing the workspace up to it makes the signal mean something again.
  • Because the job never got past clippy, the fast test tier had never actually run in CI: its watchdog is sized for a hung test, not for the dependency rebuild that each package selection triggers, so it died before a test executed. Building untimed first is what lets the tier report on tests rather than on compile time.
  • Admin endpoints now share the richer WalError to ApiError mapping, so a TooLarge or a retryable store error answers 503 instead of 500. That is the only behavior change.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 107 files, which is 7 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: a41813c2-ac19-43ff-8ea7-c416bcc94263

📥 Commits

Reviewing files that changed from the base of the PR and between 6d8fa54 and ed21b53.

📒 Files selected for processing (107)
  • Cargo.toml
  • crates/walgit-bundle/src/lib.rs
  • crates/walgit-bundle/src/ops.rs
  • crates/walgit-bundle/src/render.rs
  • crates/walgit-bundle/src/schedule.rs
  • crates/walgit-bundle/src/slots.rs
  • crates/walgit-bundle/tests/bundle.rs
  • crates/walgit-cli/src/bundle_cmd.rs
  • crates/walgit-cli/src/compact.rs
  • crates/walgit-cli/src/config_cmd.rs
  • crates/walgit-cli/src/import.rs
  • crates/walgit-cli/src/import_direct.rs
  • crates/walgit-cli/src/lib.rs
  • crates/walgit-cli/src/mirror.rs
  • crates/walgit-cli/src/repo.rs
  • crates/walgit-cli/src/serve.rs
  • crates/walgit-cli/src/synth.rs
  • crates/walgit-cli/src/wal_cmd.rs
  • crates/walgit-config/src/lib.rs
  • crates/walgit-git/src/follow.rs
  • crates/walgit-git/src/lib.rs
  • crates/walgit-git/src/pkt.rs
  • crates/walgit-git/src/receive.rs
  • crates/walgit-git/src/repair.rs
  • crates/walgit-git/src/upload_gix.rs
  • crates/walgit-git/tests/commit_graph.rs
  • crates/walgit-git/tests/common/mod.rs
  • crates/walgit-git/tests/connectivity.rs
  • crates/walgit-git/tests/ingest.rs
  • crates/walgit-git/tests/ls_refs.rs
  • crates/walgit-git/tests/refs.rs
  • crates/walgit-git/tests/refs500k.rs
  • crates/walgit-git/tests/rev_index.rs
  • crates/walgit-git/tests/upload_gix_remote.rs
  • crates/walgit-git/tests/upload_gix_scale.rs
  • crates/walgit-git/tests/upload_pack.rs
  • crates/walgit-proto/src/lib.rs
  • crates/walgit-server/build.rs
  • crates/walgit-server/src/admin.rs
  • crates/walgit-server/src/auth.rs
  • crates/walgit-server/src/bridge.rs
  • crates/walgit-server/src/bundles.rs
  • crates/walgit-server/src/cache.rs
  • crates/walgit-server/src/error.rs
  • crates/walgit-server/src/events.rs
  • crates/walgit-server/src/follow.rs
  • crates/walgit-server/src/forward.rs
  • crates/walgit-server/src/instance.rs
  • crates/walgit-server/src/lfs.rs
  • crates/walgit-server/src/lfs_upstream.rs
  • crates/walgit-server/src/lib.rs
  • crates/walgit-server/src/maintain.rs
  • crates/walgit-server/src/metrics.rs
  • crates/walgit-server/src/middleware.rs
  • crates/walgit-server/src/ops.rs
  • crates/walgit-server/src/pktline.rs
  • crates/walgit-server/src/policy.rs
  • crates/walgit-server/src/prewarm.rs
  • crates/walgit-server/src/rebuild.rs
  • crates/walgit-server/src/settings.rs
  • crates/walgit-server/src/smart.rs
  • crates/walgit-server/src/sse.rs
  • crates/walgit-server/src/static_object.rs
  • crates/walgit-server/src/stream.rs
  • crates/walgit-server/src/telemetry.rs
  • crates/walgit-server/src/tls.rs
  • crates/walgit-server/src/web/api.rs
  • crates/walgit-server/src/web/login.rs
  • crates/walgit-server/src/web/mod.rs
  • crates/walgit-server/src/web/objects.rs
  • crates/walgit-server/src/web/trailers.rs
  • crates/walgit-server/src/web/ui.rs
  • crates/walgit-server/src/web/v1.rs
  • crates/walgit-server/tests/api_v1.rs
  • crates/walgit-server/tests/drain.rs
  • crates/walgit-server/tests/e2e.rs
  • crates/walgit-server/tests/events.rs
  • crates/walgit-server/tests/follow.rs
  • crates/walgit-server/tests/harness.rs
  • crates/walgit-server/tests/lfs_upstream.rs
  • crates/walgit-server/tests/maintain.rs
  • crates/walgit-server/tests/routing_prefix.rs
  • crates/walgit-server/tests/sim.rs
  • crates/walgit-server/tests/static_http.rs
  • crates/walgit-server/tests/web_api.rs
  • crates/walgit-server/tests/web_ui.rs
  • crates/walgit-store/src/coord.rs
  • crates/walgit-store/src/fault.rs
  • crates/walgit-store/src/gcs.rs
  • crates/walgit-store/src/lib.rs
  • crates/walgit-store/src/memory.rs
  • crates/walgit-store/src/s3.rs
  • crates/walgit-store/src/util.rs
  • crates/walgit-store/tests/contract.rs
  • crates/walgit-wal/src/checkpoint.rs
  • crates/walgit-wal/src/handle.rs
  • crates/walgit-wal/src/lockwait.rs
  • crates/walgit-wal/src/log_reader.rs
  • crates/walgit-wal/src/progress.rs
  • crates/walgit-wal/src/publish.rs
  • crates/walgit-wal/src/registry.rs
  • crates/walgit-wal/src/remote.rs
  • crates/walgit-wal/src/state.rs
  • crates/walgit-wal/src/sync.rs
  • crates/walgit-wal/src/tasks.rs
  • crates/walgit-wal/tests/wal.rs
  • justfile

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis
yordis force-pushed the yordis/fix-clippy-gate branch 2 times, most recently from 23fc92c to 15a96c5 Compare September 1, 2026 09:48
The strict gate landed in 5ccc405 without the code that satisfies it, so
every branch and every fork inherits a red CI that says nothing about the
change under review.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
The watchdog is there to catch a hung test, but each line's package selection
resolves features on its own, so a line can spend the whole budget rebuilding
dependencies and die before a single test runs.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/fix-clippy-gate branch from df1e83b to ed21b53 Compare September 1, 2026 13:23
@yordis
yordis merged commit 65d1485 into main Sep 1, 2026
4 checks passed
@yordis
yordis deleted the yordis/fix-clippy-gate branch September 1, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant