fix(container): install the protobuf well-known types in the build stage - #3
Merged
Merged
Conversation
The canary image build is the only place that installs protoc with --no-install-recommends, so it was the only place that never got the include tree walgit-proto compiles against. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish canary imagerun onmainfailed: protoc could not resolveimport "google/protobuf/timestamp.proto".protocand the include tree it resolves the well-known types against across two packages. CI installsprotobuf-compilerwithout--no-install-recommendsand picks the second one up implicitly; the Containerfile is the only place that passes that flag, so it was the only place that never got it.mainleavescanaryand thesha-rollback tag unpublished.