Ensure blobs can be deleted following image manifest deletion. #459
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bglimepoint
force-pushed
the
fix-gc-following-deletion-of-manifest
branch
7 times, most recently
from
bcbbd2e to
2b4f2d2
Compare
Ensure that the deleted manifest is deleted properly, and hence can be garbage collected.
bglimepoint
force-pushed
the
fix-gc-following-deletion-of-manifest
branch
from
2b4f2d2 to
b7e7ed7
Compare
Contributor
Author
|
Also, as a little question, would you accept a PR making the Thanks for everything by the way, and sorry if any of this is wrong at all 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes blob deletion following manifest deletion, for us, I think... :-D
I.e. we do a
skopeo deleteand seemethod="DELETE" path="/v2/limepoint/worker/manifests/sha256:2720d04859afd43cc734208ff76ca842285defec23d43ffbfe40c65cbc6558a3" status="202"- but nothing's ever delete from disk, afawct. This is for images we manually put in the registry, not proxied ones - just to clarify :-)One thing seems to be that the GC code looks at the
manifest_blob_assoctable, but that table's populated from a trigger and then never deleted from (hence, never gc'd).Have done a pile of manual testing pushing images and then watching the gc delete things, so reasonably confident this is doing what we need :-)