feat(ci): added selene linter config, fixed lint warnings#7
Closed
DrKJeff16 wants to merge 4 commits intoTtibsi:mainfrom
Closed
feat(ci): added selene linter config, fixed lint warnings#7DrKJeff16 wants to merge 4 commits intoTtibsi:mainfrom
DrKJeff16 wants to merge 4 commits intoTtibsi:mainfrom
Conversation
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
DrKJeff16
changed the title
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
Owner
|
Please add this to the pre-commit config too, then I'll merge this in. Thanks for the patch |
Contributor
Author
|
@Ttibsi My bad, sorry, got confused with LuaCheck. Selene as of writing does not support pre-commit yet... |
Owner
Ah right. I think I might close this PR for now without merging - I don't want to have to remember to install other linters outside of pre-commit at the moment. Thank you for the patch, though. I wasn't aware Selene existed prior to this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have configured
selene's config. If you're interested , there's apre-commithook for it, too!