Votenext fix #1
Open
Votenext fix #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ekeijl, the main author of Trivia, has been a bit busy, so I'll have a look at it. I'm not really into the Trivia code though, so can you explain what was broken about votenext and how your patch fixes it? |
|
As I also posted in the Trivia Thread on my server only one could start a vote, but nobody could also vote. Instead it presents a message that (s)he has no permissions to use this command (which is totally nonsense, because they could start a vote). This is because Trivia checked if nobody voted and you have the permission. My changes only tests if the player has the permission. Fabian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the fix, so the vote next command is now working.