Skip to content

Conversation

CreeperNewGamer
Copy link

No description provided.

@github-actions github-actions bot added the pr: new extension Pull requests that add a new extension label Oct 5, 2025
@CreeperNewGamer CreeperNewGamer changed the title CreeperNewGamer add extension add extension: ShareSheet Oct 5, 2025
@ampelectrecuted
Copy link

ampelectrecuted commented Oct 5, 2025

Your image should be SVG + you need to add your extension to extensions.json (personally I would put it after close controls because both interface with the browser UI)
Also this isn't supported on Firefox desktop yet.

@CreeperNewGamer
Copy link
Author

Ok let me do this maybe later

@PPPDUD
Copy link
Contributor

PPPDUD commented Oct 16, 2025

!format

DangoCat and others added 3 commits October 16, 2025 18:36
I didn't bother to add casting past the "setdatatourl" block
@Brackets-Coder
Copy link
Contributor

!format

@Brackets-Coder
Copy link
Contributor

Brackets-Coder commented Oct 16, 2025

@CreeperNewGamer the previous commit should fix some of your issues

In the future, always try to use Scratch.Cast and Scratch.translate where applicable.

If you want this extension to appear in the gallery, you'll need to add the relevant information to extensions.json. You can view how in the contributing guidelines.

This comment was marked as resolved.

@CreeperNewGamer
Copy link
Author

Oh thanks, is this helping me so much! YAY!

@CreeperNewGamer
Copy link
Author

Also can you please appear this extension on the gallery, and you also help me creating a better thumbnail!

@Brackets-Coder
Copy link
Contributor

Also can you please appear this extension on the gallery, and you also help me creating a better thumbnail!

I'll see what I can do, but I'm not good at graphic design.

@Brackets-Coder
Copy link
Contributor

I added the line to extensions.json, so your extension should appear somewhere around the middle of the gallery if this gets merged.

@CreeperNewGamer
Copy link
Author

CreeperNewGamer commented Oct 16, 2025

Can 2 peoples review this, because of this:
image

Cast.toBool doesn't exist; toBoolean does.
@PPPDUD
Copy link
Contributor

PPPDUD commented Oct 16, 2025

Your code had a bug causing the <is share sheet supported?> block to hang forever, so I fixed it for you.

@CreeperNewGamer
Copy link
Author

Your code had a bug causing the <is share sheet supported?> block to hang forever, so I fixed it for you.

Thanks

@PPPDUD
Copy link
Contributor

PPPDUD commented Oct 16, 2025

Your code had a bug causing the <is share sheet supported?> block to hang forever, so I fixed it for you.

Thanks

Happy to help!

@PPPDUD
Copy link
Contributor

PPPDUD commented Oct 16, 2025

ShareSheet is not supported on Chromium with Ubuntu 25.04; what platforms is it supposed to work on?

@ampelectrecuted
Copy link

ShareSheet is not supported on Chromium with Ubuntu 25.04; what platforms is it supposed to work on?

This also does not work. Tested on Arch Linux, Chromium 141.0.7390.76.

@CreeperNewGamer
Copy link
Author

But is working on iPad 7th running iPadOS 18.7, for me

@CreeperNewGamer
Copy link
Author

To answer this question "what platforms is it supposed to work on" is mobile or windows 11

@CreeperNewGamer
Copy link
Author

Sorry I’m late, I was sleeping before

@CreeperNewGamer
Copy link
Author

Ah yes!

ScreenRecording_10-17-2025.06-50-26_1.mov

@CreeperNewGamer
Copy link
Author

If you now wondering with my thumbnail then you are in luck, because I updated it to svg and a better look

@PPPDUD

This comment was marked as resolved.

@CreeperNewGamer

This comment was marked as resolved.

@CreeperNewGamer

This comment was marked as resolved.

@PPPDUD

This comment was marked as resolved.

@CreeperNewGamer

This comment was marked as resolved.

@Brackets-Coder
Copy link
Contributor

Brackets-Coder commented Oct 17, 2025

This seems to be working for me on Safari Desktop
I haven't tried Firefox yet—MDN says it's not supported, but if you click on it, it says you have to enable a feature flag

@CreeperNewGamer However, I was not able to get the "set data to costume" block to work, the costume data was blank. It seems to only work with bitmap images.

@PPPDUD

This comment was marked as resolved.

@PPPDUD PPPDUD requested a review from Brackets-Coder October 17, 2025 13:39
Copy link
Contributor

@Brackets-Coder Brackets-Coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment

@Brackets-Coder
Copy link
Contributor

Brackets-Coder commented Oct 17, 2025

Also, may I inquire as to why you're developing on an iPad? (it won't make your extension less favorable if it still works and passes all the checks, but it does make it harder to develop)

@CreeperNewGamer
Copy link
Author

I'm having issues to accept this, but when I figure it out then I accept it!

@Brackets-Coder
Copy link
Contributor

I'm having issues to accept this, but when I figure it out then I accept it!

I'm confused.

@CreeperNewGamer
Copy link
Author

CreeperNewGamer commented Oct 17, 2025

Also, may I inquire as to why you're developing on an iPad? (it won't make your extension less favorable if it still works and passes all the checks, but it does make it harder to develop)

Sorry, but I have a time limit on my computer, so I use my iPad instead 😕!

@CreeperNewGamer
Copy link
Author

I'm having issues to accept this, but when I figure it out then I accept it!

I'm confused.

I mean the request change

@CreeperNewGamer
Copy link
Author

I did this by accident, oops
image
or I’m confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new extension Pull requests that add a new extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants