@turf/clusters-dbscan: Fix clustersDbscan not respecting units option#3026
Open
mradlinski wants to merge 1 commit into
Open
@turf/clusters-dbscan: Fix clustersDbscan not respecting units option#3026mradlinski wants to merge 1 commit into
mradlinski wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for the PR and pointing out where the broken behavior was introduced, it was really helpful as a jumping off poit to start looking into this. The PR itself has been reverted and released as 7.3.5. Is there any chance you have time to rebase this PR and have it just add the test case so we make sure not to break things going forward? If I misunderstood and we still need some form of fix in addition to the test, let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
clustersDbscanrespected theunitsoption in regards tomaxDistance.It seems this was overlooked when switching to
kdbushin 6e4c18b .This PR fixes it by converting
maxDistancefrom whatever unit was passed in the option to kilometers (which are used internally bykdbush).A test was added to check if units are respected for kilometers, meters and degrees.
I didn't find an issue for this, and thought that perhaps for such a simple issue one wasn't needed before creating a PR, sorry if that's the wrong workflow in this project.