fix: Made selectionChange also trigger on focus
#1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
reviewed
Jan 6, 2025
| @@ -730,22 +730,6 @@ export class BlockNoteEditor< | |||
| traverseBlockArray(blocks); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
did we deprecate these methods?
There was a problem hiding this comment.
Yep see line 366 and below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/blocknote/issue/BLO-81/onselectionchange-behavior
@YousefED do we actually want this behaviour? The changes in this PR I think fix what the issue describes, but I don't know if it's what we want.