feat: Page break #1372
Open
feat: Page break #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Nice!
Two things;
- I'm not sure we want it as part of the default schema. It's quite specific and only relevant if you're printing / exporting
- maybe add this CSS so it works for printing as well? https://www.w3schools.com/cssref/pr_print_pageba.php
|
# Conflicts: # packages/xl-docx-exporter/src/docx/__snapshots__/basic/document.xml # packages/xl-pdf-exporter/src/pdf/__snapshots__/example.jsx # packages/xl-pdf-exporter/src/pdf/__snapshots__/exampleWithHeaderAndFooter.jsx # shared/testDocument.ts
YousefED
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Couple of things:
- Can we align the drag handle better?
- can we make the design a bit nicer? e.g. dotted line that's grey instead of black dashes? Maybe @areknawo can later also add "Page break" in the middle, but that's non blocking
- The "Default schema" showcase actually doesn't show the default schema any more because it also adds multi-column + page break. We should update the example to reflect this
- Maybe add the page break block to the pdf and docx examples? Because now there's no easy way to test this functionality easily
YousefED
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a page break block, dedicated for use with exporters to force page breaks in the documents.