feat: make it possible to abort AI requests #1806
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
nperez0111
reviewed
Jul 8, 2025
Comment on lines
+308
to
+313
| if (state === "closed") { | ||
| throw new Error("abort() is only valid during LLM execution"); | ||
| } | ||
| if (state.status !== "thinking" && state.status !== "ai-writing") { | ||
| throw new Error("abort() is only valid during LLM execution"); | ||
| } |
There was a problem hiding this comment.
I think this should be an early return, user-facing functionality should not throw errors when it is trivial to know.
This would be similar to having to check if you can abort something before you abort it. It should just no-op
| } else { | ||
| // we were not writing yet. Set to the previous state | ||
| if (startState.status === "error") { | ||
| this.setAIResponseStatus({ status: startState.status, error: e }); |
There was a problem hiding this comment.
We want to show the abort error again?
| <Components.SuggestionMenu.Loader | ||
| className={"bn-suggestion-menu-loader bn-combobox-right-section"} | ||
| /> | ||
| // TODO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1751