Skip to content

Font Validator: Fix loading mkv subtitles and fonts in some cases #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Funami580 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Font Validator: Fix loading mkv subtitles and fonts in some cases #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/fontvalidator/fontvalidator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,14 +323,19 @@ def get_dicts(parent, element, id=False):
return ({x.name: x for x in elem} for elem in get_elements(parent, element, id=id))


def normalize_mimetype(mimetype):
if isinstance(mimetype, str):
return bytes(mimetype, encoding="raw_unicode_escape")
return mimetype

def get_subtitles(mkv):
subtitles = []

for segment in get_elements(mkv, "Segment"):
tracks_to_read = {}
tracks = get_element(segment, "Tracks")
for track in get_dicts(tracks, "TrackEntry"):
if track["CodecID"].value != b'S_TEXT/ASS':
if normalize_mimetype(track["CodecID"].value) != b'S_TEXT/ASS':
continue

compression = False
Expand Down Expand Up @@ -402,7 +407,7 @@ def get_fonts(mkv):
for segment in get_elements(mkv, "Segment"):
for attachments in get_elements(segment, "Attachments"):
for attachment in get_dicts(attachments, "AttachedFile"):
if attachment["FileMimeType"].value not in FONT_MIMETYPES:
if normalize_mimetype(attachment["FileMimeType"].value) not in FONT_MIMETYPES:
print(f"Ignoring non-font attachment {attachment['FileName'].value}")
continue

Expand Down