Potential fix for code scanning alert no. 8: Incomplete multi-character sanitization #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const content = marked.parse(audioText).replace(/<[^>]+>/g, ""); | ||
| const sanitizedHtml = DOMPurify.sanitize(marked.parse(audioText)); | ||
| const content = sanitizedHtml.replace(/<[^>]+>/g, ""); |
Check failure
Code scanning / CodeQL
Incomplete multi-character sanitization High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 months ago
To fix this issue:
- Replace the regular expression
/<[^>]+>/gwith a more complete sanitization mechanism to ensure all unsafe HTML content is removed. This can be achieved usingDOMPurify'ssanitizewith a configuration that excludes all HTML tags. - Use
DOMPurifyto fully sanitize and strip the content, ensuring no residual HTML or tags are present. This avoids potential vulnerabilities caused by relying on a regular expression.
Changes will be made to line 352 to use DOMPurify.sanitize with the ALLOWED_TAGS option set to an empty array, effectively removing all HTML tags.
Suggested changeset
1
frontend/src/pages/CasePage/Transcriptions.jsx
| @@ -348,8 +348,8 @@ | ||
| doc.text("Transcription:", margin, y); | ||
| y += 10; | ||
|
|
||
| const sanitizedHtml = DOMPurify.sanitize(marked.parse(audioText)); | ||
| const content = sanitizedHtml.replace(/<[^>]+>/g, ""); | ||
| const sanitizedHtml = DOMPurify.sanitize(marked.parse(audioText), { ALLOWED_TAGS: [], ALLOWED_ATTR: [] }); | ||
| const content = sanitizedHtml; | ||
| const lines = doc.splitTextToSize(content, 180); | ||
|
|
||
| for (let i = 0; i < lines.length; i++) { |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/UBC-CIC/Legal-Aid-Tool/security/code-scanning/8
To fix the issue, the sanitization of the parsed Markdown content should be done using a robust and well-tested library rather than relying on a custom regular expression. The
DOMPurifylibrary is already imported in the file and is specifically designed to sanitize HTML content effectively. By usingDOMPurify.sanitize()on the parsed HTML frommarked.parse(audioText), we can ensure that all potentially harmful tags and attributes are removed. This eliminates the risk of injection vulnerabilities.Suggested fixes powered by Copilot Autofix. Review carefully before merging.