Open
Conversation
eomielan
reviewed
Nov 16, 2024
Comment on lines
+110
to
+111
| apparent_wind_vel = np.subtract(rel_wind_vel, self.relative_velocity[0:2]) | ||
| apparent_water_vel = np.subtract(rel_water_vel, self.relative_velocity[0:2]) |
Member
There was a problem hiding this comment.
Please check if slicing ([0:2]) is still necessary after fluid generation update.
Contributor
Author
There was a problem hiding this comment.
It should have been fixed. Will check tomorrow to confirm.
…into user/stevenxu27/404-Complete-Boat-State-Class
…into user/stevenxu27/404-Complete-Boat-State-Class
…into user/stevenxu27/404-Complete-Boat-State-Class
FireBoyAJ24
previously approved these changes
Jun 22, 2025
…teven's original tests and test_model2 is krista's tests from PR 471
Contributor
|
@stevenxu27 Is this still active? |
Contributor
Author
Currently doing some testing with data visualization for the simulator to test this issue |
Contributor
|
@stevenxu27 I understand you’re leaving Sailbot. I’m guessing you won’t be working on this PR project anymore. I’ll ask Alberto to assign it to someone else. Please let me know if you’re still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Verification
tests/unit/nodes/physics_engineunder the test_model.py` test the functions of computing net force and torque on the sailboat overall.Resources