Add global path to centralized testing plan for local pathfinding#827
Open
Add global path to centralized testing plan for local pathfinding#827
Conversation
SPDonaghy
requested review from
FireBoyAJ24 and
raghumanimehta
as code owners
Contributor
|
@SPDonaghy, have you not tested this PR yet? The checkbox is unchecked in the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on #760 by adding global paths to the centralized test plan as well, completing the centralized testing plan story.
This PR makes some modifications to test_plan.py and the mock global path node to ensure global path data for tests comes from a test plan file instead of the csv file.
Verification
Future work on global path related things will be to tidy up a few things in the actual
global_path.pyfile which is to be used for production. There is a hardcoded path in that file that I'd like to remove.