-
Notifications
You must be signed in to change notification settings - Fork 0
Finalise backend-agnosticity of Distribution
s
#33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
willGraham01
wants to merge
42
commits into
main
Choose a base branch
from
wgraham/distributions-are-backend-agnostic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b28001
to
775489f
Compare
willGraham01
commented
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review with some typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates the
Translator
class, which expands on theBackendAgnostic
ABC. ATranslator
is aware of thebackend_obj
(backend object), and also aware of the signature of the required_frontend_method
s.On instantiation, one can pass a sequence of
Translation
objects - essentiallydataclass
wrappers for the arguments toconvert_signature
- to aTranslator
. For each_frontend_method
, theTranslator
stores the map between the arguments the frontend method takes, and the arguments the corresponding backend method takes. This means that theTranslator
can be used by the frontend, and will have the expected syntax, but also takes care of the necessary mapping of the arguments provided by the frontend to those that the backend takes. There is a simple example of this in action in the tests for theTranslator
class, however the tests for different backends demonstrate how this functionality is envisioned to be used.The
Distribution
class now inherits fromTranslator
. TheNativeDistribution
class has also been introduced, for us to use as the "base" for any standard distributions that we want to provide via ourjax
-default backend. This class simply defaults all the "translations" to the identity map (IE, the arguments and method names of the backend are already what we expect of the frontend).Users should use the
Distribution
class when they want to use a backend that is different to our "standard" backend (jax
). If they envision using multiple distributions from the same backend, they can create a derived class to reduce the number of times they need to provide the mapping information, for exampleOther Changes
convert_signature
now returns the function that maps the frontend arguments to their backend counterparts, rather than the function that does this and then evaluates the backend function. This is so that we can recycle the staticidentity
map method ofTranslator
.