Skip to content

fix(ui5-table-growing): add rootMargin to observer #11242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonkeyCo merged 5 commits into from
Apr 9, 2025
Merged

fix(ui5-table-growing): add rootMargin to observer #11242

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1738cb
fix(ui5-table-growing): add rootMargin to observer
DonkeyCo Apr 2, 2025
6e91a2d
chore: revert vertical scroll container check
DonkeyCo Apr 7, 2025
c40afda
fix: change start point to table
DonkeyCo Apr 7, 2025
f3947b3
Merge branch 'main' into fix-growing-scroll
DonkeyCo Apr 7, 2025
a2cffaa
Merge branch 'main' into fix-growing-scroll
DonkeyCo Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/main/src/TableGrowing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
TABLE_MORE,
TABLE_MORE_DESCRIPTION,
} from "./generated/i18n/i18n-defaults.js";
import { findVerticalScrollContainer } from "./TableUtils.js";

// The documentation should be similar to the Table.ts class documentation!
// Please only use that style where it uses markdown and the documentation is more readable.
Expand Down Expand Up @@ -225,7 +226,10 @@ class TableGrowing extends UI5Element implements ITableGrowing {
*/
_getIntersectionObserver(): IntersectionObserver {
if (!this._observer) {
this._observer = new IntersectionObserver(this._onIntersection.bind(this), { root: document });
this._observer = new IntersectionObserver(this._onIntersection.bind(this), {
root: findVerticalScrollContainer(this._table ?? document.body),
rootMargin: "5px",
});
}
return this._observer;
}
Expand Down