Skip to content

Conversation

@TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented Nov 5, 2025

JIRA: BGSOFUIRODOPI-3384

Certain styles for slotted elements in the footer and header are overridden, similar to how it is done in the UI5 dialog.

fixes #8167
fixes #12088

@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Nov 10, 2025

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 10, 2025 12:02 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 11, 2025 13:13 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 14, 2025 14:32 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 17, 2025 12:48 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 17, 2025 12:55 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 25, 2025 13:21 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 25, 2025 13:44 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 26, 2025 08:13 Inactive
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my UA perspective.

Copy link
Member

@alexandar-mitsev alexandar-mitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. now a popover opened from the right edge of the screen has the resize handle also on the right edge. See screenshot
image
  1. with the latest changes, if you make this sample "Test open popup and hide opener
    " resizable, it can not be resized - the popover hides the moment you click on the resize handle

_width?: string;
_height?: string;

_resizeMouseMoveHandler: (e: MouseEvent) => void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may consider moving all those private properties and most of the resize related logic inside a second class, e.g. PopoverResize.ts. It can contain the methods you need, like getResizeHandleClasses, onClose, attachMouseEvents, reset, isResizeHandleClicked and etc.
This will make the Popover.ts easier to read.
Could be separate BLI

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 4, 2025 08:37 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 16, 2025 12:37 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 17, 2025 12:55 Inactive
Copy link
Member

@alexandar-mitsev alexandar-mitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(partial review)

  • the error for popovers without opener is back
    To reproduce - set resizable: true for all popovers at Popover.html test page.
    The console has the exception:
    Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getBoundingClientRect')
    at PopoverResize.getResizeHandlePlacement (PopoverResize.ts?t=1766136059469:80:31)
    at PopoverResize.setCorrectResizeHandleClass (PopoverResize.ts?t=1766136059469:57:18)

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 19, 2025 11:33 Inactive
@TeodorTaushanov
Copy link
Member Author

(partial review)

  • the error for popovers without opener is back
    To reproduce - set resizable: true for all popovers at Popover.html test page.
    The console has the exception:
    Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getBoundingClientRect')
    at PopoverResize.getResizeHandlePlacement (PopoverResize.ts?t=1766136059469:80:31)
    at PopoverResize.setCorrectResizeHandleClass (PopoverResize.ts?t=1766136059469:57:18)

Done


const opener = popover.getOpenerHTMLElement(popover.opener);

if (!opener) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to result in wrong placement of resize handle sometimes. The handle moves to the correct spot only after the user clicks on it. Maybe the position should be re-calculated once more after open, but before the user clicks on it

To reproduce - use Popover.html, first sample in section Dynamic. When you click the three dots and open the popover - the handle is bottom right, but if you drag it it moves to bottom left.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to make ResponsivePopover resizable [Feature Request]: Allow resize option for ResponsivePopover

5 participants