-
Notifications
You must be signed in to change notification settings - Fork 279
feat(ui5-list): add sticky header property #12782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kineticjs
wants to merge
7
commits into
UI5:main
Choose a base branch
from
kineticjs:list-add-sticky-header
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+238
−32
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e345b56
feat(ui5-list): add sticky header property
kineticjs 2ee134c
Merge remote-tracking branch 'origin/main' into list-add-sticky-header
kineticjs 97d23ff
feat(ui5-list): update sample
kineticjs d6f4975
feat(ui5-list): update sample
kineticjs d035aea
feat(ui5-list): correct start-end markers of scroll container
kineticjs 553f0d2
feat(ui5-list): remove redundant newlined
kineticjs 10e215a
Merge branch 'main' into list-add-sticky-header
PetyaMarkovaBogdanova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
packages/website/docs/_samples/main/List/StickyHeader/StickyHeader.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import html from '!!raw-loader!./sample.html'; | ||
| import js from '!!raw-loader!./main.js'; | ||
|
|
||
| <Editor html={html} js={js} /> |
8 changes: 8 additions & 0 deletions
8
packages/website/docs/_samples/main/List/StickyHeader/main.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| .scrollContainer { | ||
| height: 300px; | ||
| overflow: auto; | ||
| } | ||
|
|
||
| .heading { | ||
| margin: 2rem 0 2rem 1rem; | ||
| } |
4 changes: 4 additions & 0 deletions
4
packages/website/docs/_samples/main/List/StickyHeader/main.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import "@ui5/webcomponents/dist/List.js"; | ||
| import "@ui5/webcomponents/dist/ListItemStandard.js"; | ||
|
|
||
| import "@ui5/webcomponents-icons/dist/nutrition-activity.js"; |
46 changes: 46 additions & 0 deletions
46
packages/website/docs/_samples/main/List/StickyHeader/sample.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <!-- playground-fold --> | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Sticky Header Sample</title> | ||
| <link rel="stylesheet" href="./main.css"> | ||
| </head> | ||
|
|
||
| <body style="background-color: var(--sapBackgroundColor)"> | ||
| <!-- playground-fold-end --> | ||
|
|
||
| <div class="scrollContainer"> | ||
| <ui5-title size="H3" class="heading">Scroll down to see the sticky header in action</ui5-title> | ||
| <ui5-list header-text="Sticky Header" sticky-header> | ||
| <ui5-li icon="nutrition-activity" description="Tropical plant with an edible fruit" additional-text="In-stock" | ||
| additional-text-state="Positive">Pineapple</ui5-li> | ||
| <ui5-li icon="nutrition-activity" description="Occurs between red and yellow" additional-text="Expires" | ||
| additional-text-state="Critical">Orange</ui5-li> | ||
| <ui5-li icon="nutrition-activity" description="The yellow lengthy fruit" additional-text="Re-stock" | ||
| additional-text-state="Information">Blueberry</ui5-li> | ||
| <ui5-li icon="nutrition-activity" description="The tropical stone fruit" additional-text="Re-stock" | ||
| additional-text-state="Negative">Mango</ui5-li> | ||
| <ui5-li icon="nutrition-activity" description="A sweet red or green pomaceous fruit" additional-text="In-stock" | ||
| additional-text-state="Positive">Apple</ui5-li> | ||
| <ui5-li icon="nutrition-activity" description="A long curved fruit with soft sweet flesh" additional-text="Expires" | ||
| additional-text-state="Critical">Banana</ui5-li> | ||
| <ui5-li icon="nutrition-activity" description="A small red fruit with seeds on the outside" additional-text="In-stock" | ||
| additional-text-state="Positive">Strawberry</ui5-li> | ||
| <ui5-li icon="nutrition-activity" description="A small juicy fruit growing in clusters" additional-text="Re-stock" | ||
| additional-text-state="Information">Grape</ui5-li> | ||
| <ui5-li icon="nutrition-activity" description="A tropical fruit with orange flesh and black seeds" additional-text="Re-stock" | ||
| additional-text-state="Negative">Papaya</ui5-li> | ||
| <ui5-li icon="nutrition-activity" description="A small brown fruit with bright green flesh" additional-text="In-stock" | ||
| additional-text-state="Positive">Kiwi</ui5-li> | ||
| </ui5-list> | ||
| </div> | ||
|
|
||
| <!-- playground-fold --> | ||
| <script type="module" src="main.js"></script> | ||
| </body> | ||
|
|
||
| </html> | ||
| <!-- playground-fold-end --> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.