fix(i18n): handle utf-8 escape sequences in message bundle properties files #12784
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
reviewed
Dec 10, 2025
packages/tools/lib/i18n/toJSON.js
Outdated
|
|
||
| const convertToJSON = async (file, distPath) => { | ||
| const properties = PropertiesReader(file)._properties; | ||
| inlineUTF(properties); |
Contributor
There was a problem hiding this comment.
Minor: Lets assign that to properties because it's not very intuitive that properties will be object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translation systems can output two formats for
messagebundle_XX.propertiesfiles:either UTF-8, or UTF encoded escape sequences.
Our tooling handles UTF-8 correctly:
verfügbarEscape sequences are read by the properies files reader with two slashes and incorrectly shown on screen like:
verf\u00FCgbarThis fix inlines the escape sequenses making the
.jsonfiles work correctly, while also being smaller and more readable.