fix(framework): call appyTheme on delayed theme registration after framework boot
#12787
+84
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🚀 Deployed on https://pr-12787--ui5-webcomponents-preview.netlify.app |
ilhan007
changed the title
appyTheme after boot upon delayed theme register and custom theme in useappyTheme on delayed theme registration after framework boot
ilhan007
requested review from
nnaydenow,
pskelin and
vladitasev
and removed request for
vladitasev
ilhan007
changed the title
appyTheme on delayed theme registration after framework bootappyTheme on delayed theme registration after framework boot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When theme parameters loader is registered (via
registerThemePropertiesLoadermethod) afterbootand external (custom) theme is in use, theapplyThemeisn't being called again, which leads to missing CSS variables and visual issues.There is already a handler (
onThemeRegistered) that executes upon theme parameters registration, however the handler will callapplyThemeonly if the theme that the loader is registered for matches the current theme.This change adds one more condition - checking the "base theme" of the currently set theme.
The "base theme" is present in the case of a external (custom) theme - e.g. the one that the custom theme is derived from.
Related to: #12779