Skip to content

Multiple minor fixes#24

Merged
prasannals merged 12 commits intoUMass-Rescue:mainfrom
prasannals:main
Apr 13, 2025
Merged

Multiple minor fixes#24
prasannals merged 12 commits intoUMass-Rescue:mainfrom
prasannals:main

Conversation

@prasannals
Copy link
Copy Markdown
Collaborator

@prasannals prasannals commented Apr 6, 2025

  • Migration instructions have been updated to add instructions for how to test the plugins.
  • Removed flask-ml dependency.
  • Not specifying specific version numbers in plugin pyproject.toml.
  • Using pathlib.Path to support paths in multiple platforms.
  • Raising ValueError if Ollama throws a ResponseError (occurs in multiple situations, including when the model isn't supported in the ollama version).

@prasannals prasannals requested review from nb950 and sahilx13 April 6, 2025 18:06
@prasannals prasannals changed the title Improve migration instructions Multiple minor fixes Apr 8, 2025
Comment on lines +12 to +13
"onnxruntime",
"opencv-python"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you have to put * here and put a version in the project root again so that everybody knows what versions are being used and if there is a project level conflict, then it gets resolved there

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment on lines +11 to +12
"ollama",
"pypdf2"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above comment.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@prasannals prasannals merged commit 0812e47 into UMass-Rescue:main Apr 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants