fix: remove from toggled property of Switch component in UNDP Design System because of some issue of reactivity in svelte 5. Use onchange event instead.#4929
Merged
JinIgarashi merged 1 commit intodevelopfrom Apr 17, 2025
Conversation
…System because of some issue of reactivity in svelte 5. Use onchange event instead.
🦋 Changeset detectedLatest commit: 38f361b The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request!
Description
fixes #4924
I found Switch control had some issues when bind toggled property in svelte 5. I removed $bindable for toggled prop, and use onchange event instead.
Type of Pull Request
Verify the followings
developbranchpnpm buildpnpm lintpnpm testand lint the project withpnpm lintandpnpm checkChangesets
packagesfolder that should be noted in one or more packages' changelogs, generate a changeset by runningpnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Refer to CONTRIBUTING.MD for more information.