Skip to content

fix: remove from toggled property of Switch component in UNDP Design System because of some issue of reactivity in svelte 5. Use onchange event instead.#4929

Merged
JinIgarashi merged 1 commit intodevelopfrom
fix/4924-switch-component
Apr 17, 2025
Merged

fix: remove from toggled property of Switch component in UNDP Design System because of some issue of reactivity in svelte 5. Use onchange event instead.#4929
JinIgarashi merged 1 commit intodevelopfrom
fix/4924-switch-component

Conversation

@JinIgarashi
Copy link
Copy Markdown
Contributor

Thank you for submitting a pull request!

Description

fixes #4924

I found Switch control had some issues when bind toggled property in svelte 5. I removed $bindable for toggled prop, and use onchange event instead.

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Adding tests
  • Others ()

Verify the followings

  • Code is up-to-date with the develop branch
  • No build errors after pnpm build
  • No lint errors after pnpm lint
  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
  • Make sure all the existing features working well

Changesets

  • If your PR makes a change under packages folder that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Refer to CONTRIBUTING.MD for more information.

…System because of some issue of reactivity in svelte 5. Use onchange event instead.
@JinIgarashi JinIgarashi added the bug Something isn't working label Apr 17, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 17, 2025

🦋 Changeset detected

Latest commit: 38f361b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@undp-data/svelte-geohub-static-image-controls Patch
@undp-data/svelte-undp-components Patch
@undp-data/svelte-undp-design Patch
geohub Patch
@undp-data/svelte-maplibre-storymap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@auto-assign auto-assign Bot requested review from Thuhaa and iferencik April 17, 2025 06:08
@JinIgarashi JinIgarashi temporarily deployed to Svelte UNDP Design April 17, 2025 06:08 — with GitHub Actions Inactive
@JinIgarashi JinIgarashi temporarily deployed to Svelte UNDP Components April 17, 2025 06:08 — with GitHub Actions Inactive
@JinIgarashi JinIgarashi merged commit 1ed3137 into develop Apr 17, 2025
13 checks passed
@JinIgarashi JinIgarashi deleted the fix/4924-switch-component branch April 17, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] help button is not rendered correctly in storymap editor

1 participant