Skip to content

fix: previously simulation button on CEEI dashboard was disabled when the page is shown.#4939

Merged
JinIgarashi merged 1 commit intodevelopfrom
fix/1937-ceei-simulation-button
Apr 21, 2025
Merged

fix: previously simulation button on CEEI dashboard was disabled when the page is shown.#4939
JinIgarashi merged 1 commit intodevelopfrom
fix/1937-ceei-simulation-button

Conversation

@JinIgarashi
Copy link
Copy Markdown
Contributor

Thank you for submitting a pull request!

Description

fixes #4937

fix: previously simulation button on CEEI dashboard was disabled when the page is shown. Now the button is enabled on initial page shown. This bug was caused by svelte 5 migration which did not bind layer variable to the component correctly.

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Adding tests
  • Others ()

Verify the followings

  • Code is up-to-date with the develop branch
  • No build errors after pnpm build
  • No lint errors after pnpm lint
  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
  • Make sure all the existing features working well

Changesets

  • If your PR makes a change under packages folder that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Refer to CONTRIBUTING.MD for more information.

@JinIgarashi JinIgarashi added the bug Something isn't working label Apr 21, 2025
@auto-assign auto-assign Bot requested review from Thuhaa and iferencik April 21, 2025 06:11
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2025

🦋 Changeset detected

Latest commit: f505fca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
geohub Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JinIgarashi JinIgarashi merged commit 1f9fe6d into develop Apr 21, 2025
13 checks passed
@JinIgarashi JinIgarashi deleted the fix/1937-ceei-simulation-button branch April 21, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] simiulation button is disabled when CEEI dashboard is initially opened

1 participant