Skip to content

feat: added maplibre globe mode to GeoHub#4947

Merged
JinIgarashi merged 1 commit intodevelopfrom
feat/4942-globe-mode
Apr 22, 2025
Merged

feat: added maplibre globe mode to GeoHub#4947
JinIgarashi merged 1 commit intodevelopfrom
feat/4942-globe-mode

Conversation

@JinIgarashi
Copy link
Copy Markdown
Contributor

Thank you for submitting a pull request!

Description

fixes #4942

  • added GlobeControl for map editor, map viewer and electricity dashboard
  • deleted @watergis/maplibre-gl-sky
  • save style when projection is changed at projectiontransition event.
  • I confirmed static api works without error (it will print map as mercator map, and I think this is ok for static api)

We still need to add globe control functionality for storymap, but that can be done in another PR.

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Adding tests
  • Others ()

Verify the followings

  • Code is up-to-date with the develop branch
  • No build errors after pnpm build
  • No lint errors after pnpm lint
  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
  • Make sure all the existing features working well

Changesets

  • If your PR makes a change under packages folder that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Refer to CONTRIBUTING.MD for more information.

@JinIgarashi JinIgarashi added the enhancement New feature or request label Apr 22, 2025
@auto-assign auto-assign Bot requested review from Thuhaa and iferencik April 22, 2025 06:16
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 22, 2025

🦋 Changeset detected

Latest commit: fc70a76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
geohub Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JinIgarashi JinIgarashi temporarily deployed to Svelte UNDP Design April 22, 2025 06:16 — with GitHub Actions Inactive
@JinIgarashi JinIgarashi temporarily deployed to Svelte UNDP Components April 22, 2025 06:16 — with GitHub Actions Inactive
@JinIgarashi JinIgarashi merged commit 90f731e into develop Apr 22, 2025
26 checks passed
@JinIgarashi JinIgarashi deleted the feat/4942-globe-mode branch April 22, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] add maplibre globe control

1 participant