Skip to content

fix: bring duplicated layer to the top#4952

Merged
JinIgarashi merged 1 commit intodevelopfrom
fix/4931-add-duplicatelayer-to-top
Apr 22, 2025
Merged

fix: bring duplicated layer to the top#4952
JinIgarashi merged 1 commit intodevelopfrom
fix/4931-add-duplicatelayer-to-top

Conversation

@JinIgarashi
Copy link
Copy Markdown
Contributor

Thank you for submitting a pull request!

Description

fixes #4931

fix: previously, the order of layers in sidebar is opposite from what maplibre renders. That makes some confusion and users do not realize the first layer is actually rendered the bottom of second layer. This will bring duplicated layer to the top, so it will be the same order of maplibre.

  • previously, when duplicate layer, new layer is added to the bottom.

when users changed parameters in the first layer, it looks not being changed because it is behind the second layer. But the first layer is actually changed when the second layer is hidden.

This makes users confused because the order of layers maplibre renders is opposite.

image

  • now, new layer is added to the top

Now the order of layers in sidebar and the order of maplibre rendered layers are the same. I believe this can solve the confusion for users at least.

image

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Adding tests
  • Others ()

Verify the followings

  • Code is up-to-date with the develop branch
  • No build errors after pnpm build
  • No lint errors after pnpm lint
  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
  • Make sure all the existing features working well

Changesets

  • If your PR makes a change under packages folder that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Refer to CONTRIBUTING.MD for more information.

… maplibre renders. That makes some confusion and users do not realize the first layer is actually rendered the bottom of second layer. This will bring duplicated layer to the top, so it will be the same order of maplibre.
@JinIgarashi JinIgarashi added the bug Something isn't working label Apr 22, 2025
@auto-assign auto-assign Bot requested review from Thuhaa and iferencik April 22, 2025 11:22
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 22, 2025

🦋 Changeset detected

Latest commit: f90f34a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
geohub Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JinIgarashi JinIgarashi merged commit 80149b7 into develop Apr 22, 2025
13 checks passed
@JinIgarashi JinIgarashi deleted the fix/4931-add-duplicatelayer-to-top branch April 22, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] CEEI Dashboard Simulation does not change maplibre style when there are more than one layer

1 participant