fix: bring duplicated layer to the top#4952
Merged
JinIgarashi merged 1 commit intodevelopfrom Apr 22, 2025
Merged
Conversation
… maplibre renders. That makes some confusion and users do not realize the first layer is actually rendered the bottom of second layer. This will bring duplicated layer to the top, so it will be the same order of maplibre.
🦋 Changeset detectedLatest commit: f90f34a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request!
Description
fixes #4931
fix: previously, the order of layers in sidebar is opposite from what maplibre renders. That makes some confusion and users do not realize the first layer is actually rendered the bottom of second layer. This will bring duplicated layer to the top, so it will be the same order of maplibre.
when users changed parameters in the first layer, it looks not being changed because it is behind the second layer. But the first layer is actually changed when the second layer is hidden.
This makes users confused because the order of layers maplibre renders is opposite.
Now the order of layers in sidebar and the order of maplibre rendered layers are the same. I believe this can solve the confusion for users at least.
Type of Pull Request
Verify the followings
developbranchpnpm buildpnpm lintpnpm testand lint the project withpnpm lintandpnpm checkChangesets
packagesfolder that should be noted in one or more packages' changelogs, generate a changeset by runningpnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Refer to CONTRIBUTING.MD for more information.