Fix Groundwork Water Doc Site Navigation #146
Conversation
jbkolze
left a comment
jbkolze
left a comment
There was a problem hiding this comment.
When I run in local dev all links are broken and route to about:blank#blocked. Do you see something different?
Hero banner is also broken.
|
Fixed Hero, it had the double slash issue Also corrected for discoveries in recent path PR and merged those in from main |
krowvin
left a comment
krowvin
left a comment
There was a problem hiding this comment.
Few notes I had about specific lines
| . See{" "} | ||
| <Link | ||
| href="https://usace.github.io/#/docs/forms/dropdown" | ||
| href="https://usace.github.io/groundwork/#/docs/forms/dropdown" |
There was a problem hiding this comment.
Not sure how I missed this before
| <> | ||
| <Hero | ||
| image={`${base}FT_GIBSON_20181115.min.jpg`} | ||
| image={`${BASE_URL}FT_GIBSON_20181115.min.jpg`} |
There was a problem hiding this comment.
I'm curious if this will actually work,
I tried both /test/ and / for the local base_url and it loaded..
It doesn't show it here but it had ${BASE_URL}/name
And was also causing the double //FT_GIBSON_20181115.min.jpg
jbkolze
left a comment
jbkolze
left a comment
There was a problem hiding this comment.
There are some remaining link issues in the nav-links that need to get patched up.
Also, I don't think it happened in this PR, but it looks like the package-lock.json is out of sync. Might want to go ahead and npm install and commit that along with this PR.
jbkolze
left a comment
jbkolze
left a comment
There was a problem hiding this comment.
Thanks, looks like links are working properly now.
I'm still getting a modified package-lock.json when I run npm install. We may need to touch base to figure out what's going on there.
This PR uses what we learned from Groundwork in regards to making sure base URL are set and updates to the onclick handler usage.
The site should properly let you control click/copy links and not break when various security features cause a forced page refresh on a sub page.