Update routing and base_url #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krowvin
requested changes
Dec 2, 2025
Contributor
There was a problem hiding this comment.
Update the onClick in line 28 of App.jsx to include this
<div
onClick={getNavHelper((url) => {
// Prevent duplicate /# so we can include the hash in the href, but still let the updateHash work for client-side routing
if (url.includes("/#")) url = url.replace("/#", "");
doUpdateHash(url);
})}
>It should solve the extra /# we are getting on click
| <Text className="mb-4"> | ||
| Start with the{" "} | ||
| <Link | ||
| href={`${BASE_URL}/#/docs/forms/cwms-form`} |
Contributor
There was a problem hiding this comment.
Will want to keep #/ in so the HREF includes it for copy link / ctrl + click on all instances
krowvin
added a commit
that referenced
this pull request
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating routing in docs by removing leading /#/ can setting base_Url to be "/groundwork-water/" : "/"