Fix aprfc qpf and qtf - add try block for s3 check #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enovotny
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #354 but with fix for failing S3 file check.
This PR fixes the changes in filename on https://cbt.crohms.org/akgrids/ for the aprfc qpf and qtf grids. Added a check to see if the acquirable exists in S3 before downloading to prevent downloads. Will only acquire the latest forecast issuance.
Tested both products locally. Geoprocs work, but there is still the old name in the geoproc test data. Didn't seem to matter.
Fixes USACE/cumulus#454