Update vite #181
Open
Update vite #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarhurst
requested review from
Enovotny,
adamscarberry and
willbreitkreutz
willbreitkreutz
requested changes
Sep 16, 2025
Contributor
willbreitkreutz
left a comment
willbreitkreutz
left a comment
There was a problem hiding this comment.
Bundles should just be .js instead of .jsx, probably won't break anything, but since they shouldn't handle any jsx rendering they can stay .js. Otherwise looks good.
Contributor
There was a problem hiding this comment.
Bundles shouldn't need to be .jsx, they shouldn't have any jsx that needs to be parsed so should stay .js. Not sure if it breaks anything, but keeps the intent.
Contributor
Author
|
@willbreitkreutz is there any other changes you recommend? |
krowvin
suggested changes
Nov 24, 2025
krowvin
left a comment
krowvin
left a comment
There was a problem hiding this comment.
Not sure if that index was a test file, but would change the content in it.
| @@ -1,5 +1,5 @@ | |||
| module.exports = { | |||
| content: ["./src/**/*.{html,js}"], | |||
| content: ["./src/**/*.{html,jsx}"], | |||
| <meta name="theme-color" content="#000000" /> | ||
| <meta | ||
| name="description" | ||
| content="Web site created using Vite + React" |
There was a problem hiding this comment.
I would change the content, might mess with the site's SEO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the cumulus UI to use Vite and update the npm dependencies to remove all vulerabilities.