Skip to content

chore(api): improve query performance #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dennisgsmith merged 3 commits into from
Nov 25, 2025
Merged

chore(api): improve query performance #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dc8331
chore: add indexes with tables with many scans
dennisgsmith Nov 24, 2025
cdd7e0a
chore: improve formulas endpoint query performance by batching queries
dennisgsmith Nov 25, 2025
3efbbc3
chore: remove unused sql query
dennisgsmith Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 0 additions & 41 deletions api/internal/db/measurement.manual.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,47 +49,6 @@ func (q *Queries) TimeseriesMeasurementCollectionGetForRange(ctx context.Context
return mc, nil
}

// TimeseriesMeasurementCollectionGetForRangeEXPERIMENTAL MinMax downsampling in SQL and LTTB in Go to avoid sending large amounts of data to the api
func (q *Queries) TimeseriesMeasurementCollectionGetForRangeEXPERIMENTAL(ctx context.Context, arg TimeseriesMeasurementCollectionGetForRangeParams) (MeasurementCollection, error) {
var mc MeasurementCollection
limitSql := ""
param := []any{arg.TimeseriesID, arg.EncodedTimeWindow, arg.Threshold}
if arg.Limit != 0 {
limitSql = " limit $4"
param = append(param, arg.Limit)
}
timeseriesMeasurementListForRangeEXPERIMENTAL := `
select
ts.id timeseries_id,
t.mmt measurements
from timeseries ts
left join lateral (
select minmax_downsample_jsonb_agg(
array(
select row("time", "value")::ts_measurement
from timeseries_measurement
where timeseries_id=ts.id
and "time" <@ $2::tstzrange
order by "time" asc
%s
),
$3
) mmt ) t on true
where ts.id = $1
` + limitSql
rows, err := q.db.Query(ctx, timeseriesMeasurementListForRangeEXPERIMENTAL)
if err != nil {
return mc, err
}
mm, err := pgx.CollectRows[Measurement](rows, pgx.RowToStructByNameLax)
if err != nil {
return mc, err
}
mc.TimeseriesID = arg.TimeseriesID
mc.Items = LTTB(mm, arg.Threshold)
return mc, nil
}

type MeasurementGetter interface {
getTime() time.Time
getValue() float64
Expand Down
Loading