-
Notifications
You must be signed in to change notification settings - Fork 3
feat(api, dcs-loader, opendcs): user-defined goes telemetry #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
chore: allow <Database> parent element parsing
…platform config file
MikeNeilson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've certainly seen, and likely created, worse hacks to get a legacy tool design function in a modernish way.
| <DataSourceGroupMember SequenceNum="0"> | ||
| <DataSource Name="cdadata" Type="lrgs"> | ||
| <DataSourceArg> | ||
| hostname=cdadata.wcda.noaa.gov, port=16003, password=${env.CDADATA_PASSWORD}, username=${env.CDADATA_USERNAME} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI can also encode the hostname as a variable.
It dawn on me we should give you access to the secret for the CWMS Hosted LRGS, it doesn't hook to cdadata yet (just public.lrgs.org) but that is the intention, I just need to configure it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the feedback @MikeNeilson !
I'm not sure we need to access CWMS (or at least not at the moment). This is specficially for Geotechnical instrumentation from my understanding. If any users specifically request CWMS Hosted LRGS we can reach out to get this configured.
opendcs/rsgis/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.opendcs</groupId> | ||
| <artifactId>opendcs</artifactId> | ||
| <version>7.0.12</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this one not on maven central?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this runs in the container primarily I just had it link against the opendcs.jar that already exists there. However, java is not a language I write too often, I'd be open to any recommendations you have on best practices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should put these, specifically **/.settings in the .gitignore. I suspepect the .mvn but I'm not as familiar.
chore: gitignore eclipse **/.settings chore: set up validation types for dbimport api handler chore: add constrains for platform file keys
chore: do initial dbimport before staring routescheduler chore: configure logback to emit json logs chore: clean up mvn build process chore: move patch script to separate file
feat: add apis for user-defined goes platform config uploads