Skip to content

Conversation

@dennisgsmith
Copy link
Contributor

feat: add apis for user-defined goes platform config uploads

@dennisgsmith dennisgsmith changed the title feat(api, dcs-loader, opendcs): user-define goes telemetry feat(api, dcs-loader, opendcs): user-defined goes telemetry Dec 12, 2025
Copy link

@MikeNeilson MikeNeilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've certainly seen, and likely created, worse hacks to get a legacy tool design function in a modernish way.

<DataSourceGroupMember SequenceNum="0">
<DataSource Name="cdadata" Type="lrgs">
<DataSourceArg>
hostname=cdadata.wcda.noaa.gov, port=16003, password=${env.CDADATA_PASSWORD}, username=${env.CDADATA_USERNAME}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI can also encode the hostname as a variable.

It dawn on me we should give you access to the secret for the CWMS Hosted LRGS, it doesn't hook to cdadata yet (just public.lrgs.org) but that is the intention, I just need to configure it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the feedback @MikeNeilson !

I'm not sure we need to access CWMS (or at least not at the moment). This is specficially for Geotechnical instrumentation from my understanding. If any users specifically request CWMS Hosted LRGS we can reach out to get this configured.

<dependency>
<groupId>org.opendcs</groupId>
<artifactId>opendcs</artifactId>
<version>7.0.12</version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this one not on maven central?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this runs in the container primarily I just had it link against the opendcs.jar that already exists there. However, java is not a language I write too often, I'd be open to any recommendations you have on best practices.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should put these, specifically **/.settings in the .gitignore. I suspepect the .mvn but I'm not as familiar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants