Skip to content

Add TADA_MediaFilter to flag tab #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cristinamullin merged 12 commits into from
Jan 15, 2026
Merged

Add TADA_MediaFilter to flag tab #275

cristinamullin merged 12 commits into from
Jan 15, 2026

Conversation

@cristinamullin
Copy link
Collaborator

@cristinamullin cristinamullin commented Dec 31, 2025 •
edited
Loading

@cristinamullin
take TADA_AnalysisDataFilter out of mod_query_data_server
518eb84
@cristinamullin
Add TADA_MediaFilter to flag tab
ad232b4
@cristinamullin
update TADA_Stats usage
b564a44 
group_cols is not needed here because TADA_Stats includes TADA.ComparableDataIdentifier by default
@cristinamullin cristinamullin linked an issue Dec 31, 2025 that may be closed by this pull request
Incorporate TADA_AnalysisDataFilter #206
Closed
@github-actions
Copy link

github-actions bot commented Dec 31, 2025 •
edited
Loading

coverage-report

File Coverage Missing
All files 0% ❌
R/app_config.R 0% ❌ 22-120
R/app_server_fct_helpers.R 0% ❌ 21-63
R/app_server.R 0% ❌ 22-93
R/app_ui.R 0% ❌ 39-139
R/mod_censored.R 0% ❌ 17-462
R/mod_filter.R 0% ❌ 2-594
R/mod_flag_fct_helpers.R 0% ❌ 13-154
R/mod_flag.R 0% ❌ 10-289
R/mod_harmonize.R 0% ❌ 10-366
R/mod_load_fct_helpers.R 0% ❌ 26-50
R/mod_load_map_bbox_fct_helpers.R 0% ❌ 20-52
R/mod_load_map_bbox.R 0% ❌ 11-302
R/mod_load_upload_data.R 0% ❌ 10-37
R/mod_load.R 0% ❌ 6-1167
R/mod_overview.R 0% ❌ 10-228
R/mod_review_pie.R 0% ❌ 10-149
R/mod_review_scatterplots.R 0% ❌ 9-562
R/mod_summary.R 0% ❌ 11-50
R/mod_summary2_fct_helpers.R 0% ❌ 2-292
R/mod_summary2.R 0% ❌ 10-328
R/run_app.R 0% ❌ 16-26

Minimum allowed coverage is 10%

Generated by 🐒 cobertura-action against 3052308

@cristinamullin
fix options(old_warn) bug
9900825 
removed the manual warn restore and now use withr::local_options(list(warn = 2)) inside a tryCatch, returning a datatable widget from renderUI
@cristinamullin
styler
264bc72
@cristinamullin cristinamullin mentioned this pull request Dec 31, 2025
Closed
5 tasks
@cristinamullin cristinamullin linked an issue Dec 31, 2025 that may be closed by this pull request
Error: 'TADA_CheckRequiredFields' is not an exported object from 'namespace:EPATADA' #272
Closed
5 tasks
@cristinamullin
Update mod_review_scatterplots.R
84a3572 
Safe handling when no groups are selected (avoid indexing react$groups[1]).
Use na.rm in summaries and guard quantile/median against empty vectors.
Safe map bounds with numeric coercion.
More robust stats table column selection and labeling.
Validate/need in plots when data is missing.
@cristinamullin
remove mention of options(warn = 2)
7edf7cb
@cristinamullin
test_that("options() usage is safe and consistent"
ec4ed1c
@cristinamullin
deploy
c36e24d
@cristinamullin
Merge branch 'develop' into media-filter
47cc896
@cristinamullin
move dev
24bcfc4
@cristinamullin
Merge branch 'develop' into media-filter
3052308
@JamesBisese
Copy link
Collaborator

JamesBisese commented Jan 15, 2026 •
edited
Loading

I used git fetch origin pull/275/head:local-test-pull to bring the pull request to my computer,
and then git checkout local-test-pull to switch to the branch. Then run it (after getting all the latest stuff from EPATADA).

I now see the new row in the Filters tab
TADA.Media.Flag | 3 | TADA-standardized media fields

This particular functionality seems to work.

I looked at the code changes in the commit - and they make sense to me.

If I have permission in GitHub, I will approve the pull request.

JamesBisese
JamesBisese approved these changes Jan 15, 2026
View reviewed changes
Copy link
Collaborator

@JamesBisese JamesBisese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used git fetch origin pull/275/head:local-test-pull to bring the pull request to my computer,
and then git checkout local-test-pull to switch to the branch. Then run it (after getting all the latest stuff from EPATADA).

I now see the new row in the Filters tab
TADA.Media.Flag | 3 | TADA-standardized media fields

This particular functionality seems to work.

I looked at the code changes in the commit - and they make sense to me.

If I have permission in GitHub, I will approve the pull request.

@cristinamullin cristinamullin merged commit 7711465 into develop Jan 15, 2026
6 checks passed
@cristinamullin cristinamullin deleted the TADA_AnalysisDataFilter branch January 15, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesBisese JamesBisese JamesBisese approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: 'TADA_CheckRequiredFields' is not an exported object from 'namespace:EPATADA' Incorporate TADA_AnalysisDataFilter

3 participants

@cristinamullin @JamesBisese