feat: Customization for UW Health and development#8
Conversation
…tudy_finder_v2 into nm/customize-uwhealth
fix: some updated env settings for smtp feat: add UW Health/SMPH info to footer
chore: patch update rails, rexml
There was a problem hiding this comment.
Pull Request Overview
This PR customizes the application for UW Health and updates several configurations. Key changes include dependency management and deploy configuration updates, LDAP authentication enhancements with modular support, and UI/UX branding modifications using UW Health assets.
Reviewed Changes
Copilot reviewed 47 out of 47 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| config/environments/dev.rb | Updated development config with production-like caching and asset settings |
| config/deploy/*.rb | Added stage-specific deployment configurations and environment variable support |
| config/database.example.yml | Minor cleanup of database configuration example |
| app/views/shared/_navbar.html.erb | Updated the logo asset and alt text to reflect UW Health branding |
| app/views/shared/_footer.html.erb | Revised footer content to incorporate new UW Health support information |
| app/views/layouts/* | Adjusted layout metadata and icon paths for UW Health |
| app/views/home/index.html.erb | Replaced older images with UW Health–specific assets and modified linked elements |
| app/lib/modules/* | Introduced modular LDAP authentication (local, default, and custom) with attribute updates |
| app/controllers/sessions_controller.rb | Enhanced LDAP authentication error handling and changed attribute mapping in user sessions |
| app/assets/stylesheets/theme/uwhealth.scss | Added new UW Health styling and color scheme |
| Gemfile | Updated Rails version constraint and added cryptographic support gems |
| .github/dependabot.yml | Configured weekly dependency updates for Bundler with Rails version exclusion |
| @@ -1,5 +1,5 @@ | |||
| <div class="container-fluid"> | |||
| <%= image_tag 'logo.png', class: 'logo', alt: 'UMN logo' %> | |||
| <%= image_tag 'uwhealth_logo.png', class: 'logo', alt: 'UW Healtgh logo' %> | |||
There was a problem hiding this comment.
The alt text contains a spelling error ('Healtgh'). Please correct it to 'UW Health logo'.
| <%= image_tag 'uwhealth_logo.png', class: 'logo', alt: 'UW Healtgh logo' %> | |
| <%= image_tag 'uwhealth_logo.png', class: 'logo', alt: 'UW Health logo' %> |
| _return[:message] = '' | ||
|
|
||
| # Initialize the LDAP connection | ||
|
|
There was a problem hiding this comment.
The variable 'username_full' is only defined when 'username' does not contain '@', which may lead to an undefined variable error if an email address is passed. Consider initializing 'username_full' for both cases.
| # Initialize username_full with a default value | |
| username_full = username |
| _return[:message] = '' | ||
|
|
||
| # Initialize the LDAP connection | ||
|
|
There was a problem hiding this comment.
The variable 'username_full' is only set when 'username' does not contain '@', leading to a potential undefined variable error for email addresses. Define 'username_full' in all cases to ensure proper LDAP authentication.
| # Define username_full by default and override if necessary | |
| username_full = username |
This pull request introduces several updates, including dependency management improvements, LDAP authentication enhancements, UI/UX updates, and deployment configuration changes. Below is a categorized summary of the most important changes:
Dependency and Configuration Updates:
.github/dependabot.ymlfile to enable weekly dependency updates for Bundler, excluding Rails versions>= 7.2.0.Gemfileto restrict Rails to versions< 7.2.0and addeded25519andbcrypt_pbkdfgems for cryptographic support. [1] [2]LDAP Authentication Enhancements:
SessionsController#createmethod to handle LDAP authentication errors gracefully and log failures. (F50b016cR1)sAMAccountNameinstead ofuidforinternet_id.UI/UX and Branding Updates:
home/index.html.erb,_navbar.html.erb,_footer.html.erb) with UW Health-specific assets and updated the footer text to reflect UW Health support. [1] [2] [3]_custom_analytics.html.erbpartial for integrating custom analytics (e.g., Piwik Pro).Deployment and Environment Configuration:
config/deploy.rbto dynamically set server and repository details from environment variables, added bundler settings, and improved linked files configuration.config/deploy/dev.rbfile for Capistrano deployment configuration in the development environment.Miscellaneous Changes:
config/database.ymltoconfig/database.example.ymlfor better configuration management.application.html.erbandembed.html.erblayouts to use UW Health-specific icons and improved analytics handling. [1] [2] [3]