fix_add_special_feature_tests #778 #783
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftnext
reviewed
Nov 3, 2024
Collaborator
ftnext
left a comment
ftnext
left a comment
There was a problem hiding this comment.
Thank you for splitting the pull request.
First I have a question.
ftnext
requested changes
Nov 5, 2024
ftnext
requested changes
Nov 9, 2024
Collaborator
ftnext
left a comment
ftnext
left a comment
There was a problem hiding this comment.
Thanks for moving the test code.
Please remove all comments.
Your change can "Explain Yourself in Code (ref: Clean Code)", so it seems that there is no need for comments
Author
|
@ftnext done ✅ |
ftnext
requested changes
Dec 3, 2024
Collaborator
ftnext
left a comment
ftnext
left a comment
There was a problem hiding this comment.
Thank you for the fix so far.
I have added comments on more specifics as the code has become more concise.
| self.assertSimilar(audio.get_raw_data()[:32], b"\x00\x00\x00\x00\x00\x00\xfe\xff\x00\x00\x02\x00\x00\x00\xfe\xff\x00\x00\x00\x00\x00\xff\x01\x00\x00\x02\xfc\xff\x00\xfe\x01\x00") | ||
|
|
||
| def test_incompatible_audio_file_error(self): | ||
| self.AUDIO_FILE_EN_MP3 = path.join(path.dirname(path.realpath(__file__)), "english.mp3") |
Collaborator
There was a problem hiding this comment.
self.AUDIO_FILE_EN_MP3 -> AUDIO_FILE_EN_MP3
self seems to be unnecessary.
| self.AUDIO_FILE_EN_MP3 = path.join(path.dirname(path.realpath(__file__)), "english.mp3") | ||
| r = sr.Recognizer() | ||
| with self.assertRaises(ValueError) as context: | ||
| with sr.AudioFile(self.AUDIO_FILE_EN_MP3) as source:r.record(source) |
Collaborator
There was a problem hiding this comment.
with sr.AudioFile(AUDIO_FILE_EN_MP3) as source:
passTest target is AudioFile.__enter__(), so Recognizer is not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_incompatible_audio_file_error test failed and raised the ValueError as mp3 format.
The test_sphinx_keywords fixed the tests before as they failed
Issue #778