Skip to content

Fix: Update the document deploys to current #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rachel-Eichenberger merged 4 commits into from
Apr 10, 2024
Merged

Fix: Update the document deploys to current #683

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec49f24
Fix: Update the document deploys to current
Rachel-Eichenberger Mar 26, 2024
da5fbb7
Fix: Clean up commit
Rachel-Eichenberger Mar 27, 2024
13a81c4
Fix: Remove Goerli
Rachel-Eichenberger Mar 28, 2024
3ebd8c5
fix: Add Blast Network
Rachel-Eichenberger Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions docs/contracts/v2/reference/smart-contracts/08-deployment-addresses.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,15 @@ title: V2 Deployment Addresses

# Uniswap v2 Contract Deployments

Contract addresses for the [Uniswap V2 Factory](https://github.com/Uniswap/v2-core/blob/master/contracts/UniswapV2Factory.sol)
Contract addresses for the [`Uniswap V2 Factory`](https://github.com/Uniswap/v2-core/blob/master/contracts/UniswapV2Factory.sol) and the [`Uniswap V2Router02`](https://github.com/Uniswap/v2-periphery/blob/master/contracts/UniswapV2Router02.sol)

| Network | Contract Address |
| ---------------------------------------------------- | ----------------------------------------------- |
| Mainnet, Ropsten, Rinkeby, Goerli, Kovan | `0x5C69bEe701ef814a2B6a3EDD4B1652CB9cc5aA6f` |
| Arbitrum | `0xf1D7CC64Fb4452F05c498126312eBE29f30Fbcf9` |
| Avalanche | `0x9e5A52f57b3038F1B8EeE45F28b3C1967e22799C` |
| BNB Chain | `0x8909Dc15e40173Ff4699343b6eB8132c65e18eC6` |
| Base | `0x8909Dc15e40173Ff4699343b6eB8132c65e18eC6` |
| Optimism | `0x0c3c1c532F1e39EdF36BE9Fe0bE1410313E074Bf` |
| Polygon | `0x9e5A52f57b3038F1B8EeE45F28b3C1967e22799C` |
| Network | Factroy Contract Address | V2Router02 Contract Address |
| ---------------------------------------------------- | -------------------------------------------- | -------------------------------------------- |
| Mainnet, Ropsten, Rinkeby, Goerli, Kovan | `0x5C69bEe701ef814a2B6a3EDD4B1652CB9cc5aA6f` | `0x7a250d5630B4cF539739dF2C5dAcb4c659F2488D` |
Copy link
Member

@jsy1218 jsy1218 Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to list the deprecated testnets?

Copy link
Collaborator Author

@Rachel-Eichenberger Rachel-Eichenberger Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll remove all but Goerli, which still existing for now and only available v2

Copy link
Member

@jsy1218 jsy1218 Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm.. Goerli validators stopped producing blocks for a while https://goerli.etherscan.io/, although that precedes EF's planned deprecation date

Copy link
Member

@jsy1218 jsy1218 Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I actually had to disable Goerli from routing all together because of that. Uniswap/routing-api#500

Copy link
Collaborator Author

@Rachel-Eichenberger Rachel-Eichenberger Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, yeah, well we knew this was coming. Will have to push FE to update the supported list.

| Etherum Sepolia | `0xB7f907f7A9eBC822a80BD25E224be42Ce0A698A0` | `0x425141165d3DE9FEC831896C016617a52363b687` |
Copy link
Contributor

@just-toby just-toby Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the v2router02 contract here for Sepolia is not verified on etherscan, should we try to get that verified before publishing this?

Copy link
Contributor

@just-toby just-toby Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm also not seeing any transactions there, so just double checking that it's correct

Copy link
Member

@jsy1218 jsy1218 Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior deployed UniswapV2Router02 0x7a250d5630B4cF539739dF2C5dAcb4c659F2488 on Sepolia was verified, but it doesn't have the v2 liquidity support. 0x425141165d3DE9FEC831896C016617a52363b687 was retroactively deployed to Sepolia to support v2 liquidity. Probably the deploy was done in a rush so it was not verified.

I believe this was part of the v2-deploy-everywhere, where UniswapV2Router02 needs to support v2 liquidity as well.

Copy link
Member

@jsy1218 jsy1218 Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I think the reason there's no transaction yet is because the PR hasn't merged yet.Uniswap/sdk-core#131

Copy link
Collaborator Author

@Rachel-Eichenberger Rachel-Eichenberger Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was newly launched by Emily https://uniswapteam.slack.com/archives/C05MF1J6GR5/p1709845257901909?thread_ts=1708991083.674689&cid=C05MF1J6GR5
The script errored trying to verify the code. Yes, Blast put us behind on pushing the PR.

| Arbitrum | `0xf1D7CC64Fb4452F05c498126312eBE29f30Fbcf9` | `0x4752ba5dbc23f44d87826276bf6fd6b1c372ad24` |
| Avalanche | `0x9e5A52f57b3038F1B8EeE45F28b3C1967e22799C` | `0x4752ba5dbc23f44d87826276bf6fd6b1c372ad24` |
| BNB Chain | `0x8909Dc15e40173Ff4699343b6eB8132c65e18eC6` | `0x4752ba5dbc23f44d87826276bf6fd6b1c372ad24` |
| Base | `0x8909Dc15e40173Ff4699343b6eB8132c65e18eC6` | `0x4752ba5dbc23f44d87826276bf6fd6b1c372ad24` |
| Optimism | `0x0c3c1c532F1e39EdF36BE9Fe0bE1410313E074Bf` | `0x4A7b5Da61326A6379179b40d00F57E5bbDC962c2` |
| Polygon | `0x9e5A52f57b3038F1B8EeE45F28b3C1967e22799C` | `0xedf6066a2b290C185783862C7F4776A2C8077AD1` |
86 changes: 0 additions & 86 deletions docs/contracts/v3/reference/Deployments.md
View file
Open in desktop

This file was deleted.

Loading