wip: Add Base Sepolia support #761
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps the `sdk-core` to pull in configuration changes made in: Uniswap/sdks#192 This will be replaced by a standard version bump once that PR lands properly.
This adds the Chain ID, Addresses, and WETH token configuration for the Base Sepolia network (84532) to the smart order router. Uniswap#494
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Report is too large to display inline. Next stepsMark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
alex-stone
commented
Nov 5, 2024
| "@uniswap/permit2-sdk": "^1.3.0", | ||
| "@uniswap/router-sdk": "^1.14.0", | ||
| "@uniswap/sdk-core": "^5.9.0", | ||
| "@uniswap/sdk-core": "github:alex-stone/uniswap-sdks#alex-stone/add-base-sepolia", |
Author
There was a problem hiding this comment.
Looks like the submodule installation doesn't work nicely with the git / github syntax.
Will try to figure that out / hopefully land that PR!
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature
Base Sepolia (84532) is an unsupported chain
Base Sepolia (84532) is a supported chain
This depends on Uniswap/sdks#192 and will move out of Draft once that lands and a version is cut!
This follows up the work that @danielcrt did here, but on the new SDK monorepo:
Uniswap/sdk-core#110
#494