This repository was archived by the owner on Apr 25, 2024. It is now read-only.
[WIP] feat: SDK modernization, automated test cases, speed upgrades #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cular dependency in utils
Upgrade V3 staker
chore: dependencies, testing framework and ci
* feat: bigint instead of jsbi * feat: remove unused import * fix: tests and calculation error in swap * fix: sdk-core fork for now * fix: npm package name * fix: remove comment
* feat: bigint instead of jsbi * feat: remove unused import * fix: tests and calculation error in swap * fix: sdk-core fork for now * fix: npm package name * feat: automated test runner and 4200 test cases on edge pools * Fix code style issues with Prettier * fix: comments from review * fix: wording --------- Co-authored-by: Lint Action <[email protected]>
feat: upstream merge
Florian-S-A-W
approved these changes
Aug 29, 2023
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Author
|
Waiting for the core sdk to be merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is finalized but depends on Uniswap/sdk-core#69 being merged (we will need to update the dependency version in the package.json once the Core SDK has been published)
This is part of the sdk upgrade grant.
Updates
Important backwards compatibility notes
(Similar to the Core SDK updates)
The updates in this PR are fully source-code compatible and non-breaking. But explicit < es2020 projects will not be able to compile it.
So, if people use a modern setup, they won't have to change anything in their existing code but can start using native BigInt (and even if not will feel a performance difference).
Because of the above, I propose making a major version bump anyways. That way, users will need to explicitly opt-in to the new v3-sdk, but if they do they don't have to update any source code.